Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1881113002:
Fix references to ISO 15924 (Closed)
|
Created:
4 years, 8 months ago by rwlbuis Modified:
4 years, 8 months ago CC:
chromium-reviews, qsr+mojo_chromium.org, Aaron Boodman, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, haraken, dglazkov+blink, blink-reviews, darin (slow to review), ben+mojo_chromium.org, blink-reviews-api_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix references to ISO 15924
Fix references to ISO 15924 (script codes).
BUG=587995
Committed: https://crrev.com/d12b0c538d96a1e1242a6d47ad356f28d18f819b
Cr-Commit-Position: refs/heads/master@{#387086}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Remove include changes #
Messages
Total messages: 26 (13 generated)
Description was changed from ========== payment WIP BUG= ========== to ========== payment WIP BUG=587995 ==========
Description was changed from ========== payment WIP BUG=587995 ========== to ========== Fix reference to ISO 15924 Fix reference to ISO 15924 (script codes). BUG=587995 ==========
Description was changed from ========== Fix reference to ISO 15924 Fix reference to ISO 15924 (script codes). BUG=587995 ========== to ========== Fix references to ISO 15924 Fix references to ISO 15924 (script codes). BUG=587995 ==========
rob.buis@samsung.com changed reviewers: + rouslan@chromium.org
PTAL, I am 99% sure this is the correct ISO :) Also let me know how I can help more with Payment, for instance more/extending unit tests?
rouslan@chromium.org changed reviewers: + palmer@chromium.org
+palmer for mojom. lgtm If you're interested in helping out more, see https://bugs.chromium.org/p/chromium/issues/detail?id=602660 . You can assign that bug to yourself and start work. I have a proof-of-concept patch in there as well. Thank you!
https://codereview.chromium.org/1881113002/diff/1/third_party/WebKit/Source/m... File third_party/WebKit/Source/modules/payments/PaymentRequest.h (left): https://codereview.chromium.org/1881113002/diff/1/third_party/WebKit/Source/m... third_party/WebKit/Source/modules/payments/PaymentRequest.h:19: #include "wtf/Compiler.h" btw, let's not alter includes in this patch. This patch is for fixing the comments only.
https://codereview.chromium.org/1881113002/diff/1/third_party/WebKit/Source/m... File third_party/WebKit/Source/modules/payments/PaymentsValidators.cpp (left): https://codereview.chromium.org/1881113002/diff/1/third_party/WebKit/Source/m... third_party/WebKit/Source/modules/payments/PaymentsValidators.cpp:8: #include "wtf/text/StringImpl.h" Let's not alter includes in this patch. This patch is for fixing the comments only.
On 2016/04/12 20:42:32, Rouslan wrote: > https://codereview.chromium.org/1881113002/diff/1/third_party/WebKit/Source/m... > File third_party/WebKit/Source/modules/payments/PaymentsValidators.cpp (left): > > https://codereview.chromium.org/1881113002/diff/1/third_party/WebKit/Source/m... > third_party/WebKit/Source/modules/payments/PaymentsValidators.cpp:8: #include > "wtf/text/StringImpl.h" > Let's not alter includes in this patch. This patch is for fixing the comments > only. Ok, I'll remove that part.
lgtm
The CQ bit was checked by rob.buis@samsung.com
The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org Link to the patchset: https://codereview.chromium.org/1881113002/#ps20001 (title: "Remove include changes")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881113002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
The CQ bit was checked by rob.buis@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881113002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
The CQ bit was checked by rob.buis@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881113002/20001
Message was sent while issue was closed.
Description was changed from ========== Fix references to ISO 15924 Fix references to ISO 15924 (script codes). BUG=587995 ========== to ========== Fix references to ISO 15924 Fix references to ISO 15924 (script codes). BUG=587995 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix references to ISO 15924 Fix references to ISO 15924 (script codes). BUG=587995 ========== to ========== Fix references to ISO 15924 Fix references to ISO 15924 (script codes). BUG=587995 Committed: https://crrev.com/d12b0c538d96a1e1242a6d47ad356f28d18f819b Cr-Commit-Position: refs/heads/master@{#387086} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/d12b0c538d96a1e1242a6d47ad356f28d18f819b Cr-Commit-Position: refs/heads/master@{#387086} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
