tools/dom/templates/html/impl/impl_CustomEvent.darttemplate - Issue 18811006: Fixing CustomEvent.detail leaks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/templates/html/impl/impl_CustomEvent.darttemplate

Issue 18811006: Fixing CustomEvent.detail leaks. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/dom/templates/html/impl/impl_CustomEvent.darttemplate

diff --git a/tools/dom/templates/html/impl/impl_CustomEvent.darttemplate b/tools/dom/templates/html/impl/impl_CustomEvent.darttemplate

index be6b7ef4852a2876ae20d30c405929082c57c761..a5305e1557bfda1edfecdcfdbc2675e00a3724cd 100644

--- a/tools/dom/templates/html/impl/impl_CustomEvent.darttemplate

+++ b/tools/dom/templates/html/impl/impl_CustomEvent.darttemplate

@@ -10,7 +10,11 @@ $(ANNOTATIONS)$(CLASS_MODIFIERS)class $CLASSNAME$EXTENDS$IMPLEMENTS$NATIVESPEC {

factory $CLASSNAME(String type,

{bool canBubble: true, bool cancelable: true, Object detail}) {

- final CustomEvent e = document.$dom_createEvent("CustomEvent");

+ final CustomEvent e = document.$dom_createEvent('CustomEvent');

+$if DART2JS

+ detail = convertDartToNative_SerializedScriptValue(detail);

+$endif

e.$dom_initCustomEvent(type, canBubble, cancelable, detail);

return e;