Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Issue 18811006: Fixing CustomEvent.detail leaks. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/html/dartium/html_dartium.dart » ('j') | sdk/lib/html/dartium/html_dartium.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dart2js/html_dart2js.dart
diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart
index 65781a02d04da5d86fb9fc54f15fde32d7a286e9..902cbd8bd188509af771073539c1e0783f016223 100644
--- a/sdk/lib/html/dart2js/html_dart2js.dart
+++ b/sdk/lib/html/dart2js/html_dart2js.dart
@@ -6048,7 +6048,9 @@ class CustomEvent extends Event native "CustomEvent" {
factory CustomEvent(String type,
{bool canBubble: true, bool cancelable: true, Object detail}) {
- final CustomEvent e = document.$dom_createEvent("CustomEvent");
+ final CustomEvent e = document.$dom_createEvent('CustomEvent');
+
+ detail = convertDartToNative_SerializedScriptValue(detail);
e.$dom_initCustomEvent(type, canBubble, cancelable, detail);
return e;
@@ -6056,10 +6058,12 @@ class CustomEvent extends Event native "CustomEvent" {
// To suppress missing implicit constructor warnings.
factory CustomEvent._() { throw new UnsupportedError("Not supported"); }
+ dynamic get detail => convertNativeToDart_SerializedScriptValue(this._get_detail);
+ @JSName('detail')
@DomName('CustomEvent.detail')
@DocsEditable()
@Creates('Null')
- final Object detail;
+ final dynamic _get_detail;
@JSName('initCustomEvent')
@DomName('CustomEvent.initCustomEvent')
« no previous file with comments | « no previous file | sdk/lib/html/dartium/html_dartium.dart » ('j') | sdk/lib/html/dartium/html_dartium.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698