chrome/browser/ui/cocoa/tabs/tab_window_controller.mm - Issue 1881093002: Implement Tab Detaching in Fullscreen Mode on Mac OSX

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/tabs/tab_window_controller.mm

Issue 1881093002: Implement Tab Detaching in Fullscreen Mode on Mac OSX (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comment nit Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/browser_window_controller.mm ('K') | « chrome/browser/ui/cocoa/tabs/tab_window_controller.h ('k') | chrome/common/chrome_switches.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/tabs/tab_window_controller.mm

diff --git a/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm b/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm

index 01dcdc06a90769fac428d92e265298094e0fbf1d..07baee691dd6d40137e006f61b944da0f3e13fb1 100644

--- a/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm

+++ b/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm

@@ -255,6 +255,11 @@

return NULL;

}

+- (void)detachedWindowEnterFullscreenIfNeeded:(TabWindowController*)source {

+ // Subclasses should implement this.

+ NOTIMPLEMENTED();

- (void)insertPlaceholderForTab:(TabView*)tab frame:(NSRect)frame {

[self showNewTabButton:NO];

}

@@ -307,6 +312,12 @@

return NO;

}

+- (CGFloat)menubarOffset {

+ // Subclasses should implement this.

+ NOTIMPLEMENTED();

+ return 0;

- (NSString*)activeTabTitle {

// subclass must implement

NOTIMPLEMENTED();