Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1881053003:
Enable GPU Raster on OSX (Closed)
DescriptionThis change enables GPU Raster on OSX.
I've compiled a bit of benchmark data to support turning this on -
https://docs.google.com/a/google.com/document/d/1RPEnillJOaOKW47t9DYuttQkvWDo7ilx9KDB_nJnwpc/edit?usp=sharing
Still filling in more data, but I'm pretty happy with the results so far. In
a number of cases we have a performance win, and in most cases we have a power win.
Checking this in now will give us a long canary period before the next branch
point to catch any issues.
BUG=542959
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.blink:mac_blink_rel
Committed: https://crrev.com/8325892c2efdef8cff86ba16e7569f8b424daeda
Cr-Commit-Position: refs/heads/master@{#391655}
Patch Set 1 #Patch Set 2 : exclude Apple Software Renderer from GPU raster #Patch Set 3 : rebase #Patch Set 4 : rebase #
Messages
Total messages: 57 (30 generated)
Description was changed from ========== Enable GPU Raster on OSX This change enables GPU Raster on OSX. BUG=542959 ========== to ========== Enable GPU Raster on OSX This change enables GPU Raster on OSX. BUG=542959 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
ericrk@chromium.org changed reviewers: + piman@chromium.org, vmiura@chromium.org
This change enables GPU Raster on OSX. I've compiled a bit of benchmark data to support turning this on - https://docs.google.com/a/google.com/document/d/1RPEnillJOaOKW47t9DYuttQkvWDo.... Still filling in more data, but I'm pretty happy with the results so far. In some cases we have a performance win, but in most cases we have a power win. Checking this in now will give us a long canary period before the next branch point to catch any issues. BUG=542959 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Description was changed from ========== Enable GPU Raster on OSX This change enables GPU Raster on OSX. BUG=542959 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== This change enables GPU Raster on OSX. I've compiled a bit of benchmark data to support turning this on - https://docs.google.com/a/google.com/document/d/1RPEnillJOaOKW47t9DYuttQkvWDo.... Still filling in more data, but I'm pretty happy with the results so far. In some cases we have a performance win, but in most cases we have a power win. Checking this in now will give us a long canary period before the next branch point to catch any issues. BUG=542959 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== This change enables GPU Raster on OSX. I've compiled a bit of benchmark data to support turning this on - https://docs.google.com/a/google.com/document/d/1RPEnillJOaOKW47t9DYuttQkvWDo.... Still filling in more data, but I'm pretty happy with the results so far. In some cases we have a performance win, but in most cases we have a power win. Checking this in now will give us a long canary period before the next branch point to catch any issues. BUG=542959 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== This change enables GPU Raster on OSX. I've compiled a bit of benchmark data to support turning this on - https://docs.google.com/a/google.com/document/d/1RPEnillJOaOKW47t9DYuttQkvWDo.... Still filling in more data, but I'm pretty happy with the results so far. In a number of cases we have a performance win, and in most cases we have a power win. Checking this in now will give us a long canary period before the next branch point to catch any issues. BUG=542959 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== This change enables GPU Raster on OSX. I've compiled a bit of benchmark data to support turning this on - https://docs.google.com/a/google.com/document/d/1RPEnillJOaOKW47t9DYuttQkvWDo.... Still filling in more data, but I'm pretty happy with the results so far. In a number of cases we have a performance win, and in most cases we have a power win. Checking this in now will give us a long canary period before the next branch point to catch any issues. BUG=542959 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== This change enables GPU Raster on OSX. I've compiled a bit of benchmark data to support turning this on - https://docs.google.com/a/google.com/document/d/1RPEnillJOaOKW47t9DYuttQkvWDo... Still filling in more data, but I'm pretty happy with the results so far. In a number of cases we have a performance win, and in most cases we have a power win. Checking this in now will give us a long canary period before the next branch point to catch any issues. BUG=542959 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Docs url was wrong, here's the right one: https://docs.google.com/a/google.com/document/d/1RPEnillJOaOKW47t9DYuttQkvWDo...
LGTM
lgtm!
The CQ bit was checked by ericrk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881053003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881053003/1
That doc isn't public, you might want to paste it into a Chromium.org doc and make it world readable.
On 2016/04/18 18:52:32, esprehn wrote: > That doc isn't public, you might want to paste it into a http://Chromium.org doc and > make it world readable. Also please enable comments -- I have questions about units.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)
The CQ bit was checked by ericrk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881053003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881053003/1
On 2016/04/18 19:00:32, ccameron wrote: > On 2016/04/18 18:52:32, esprehn wrote: > > That doc isn't public, you might want to paste it into a http://Chromium.org > doc and > > make it world readable. > > Also please enable comments -- I have questions about units. Comments Enabled.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by ericrk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881053003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881053003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Patchset #7 (id:120001) has been deleted
Patchset #6 (id:100001) has been deleted
Patchset #5 (id:80001) has been deleted
Patchset #4 (id:60001) has been deleted
Looks like, after a number of fixes in other CLs, this has gone green! Victor, can you take a glance at the new software rendering list entry I added? Other than that, we should be set to land this!
On 2016/05/02 23:02:38, ericrk wrote: > Looks like, after a number of fixes in other CLs, this has gone green! Victor, > can you take a glance at the new software rendering list entry I added? Other > than that, we should be set to land this! Still LGTM.
The CQ bit was checked by ericrk@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org Link to the patchset: https://codereview.chromium.org/1881053003/#ps40001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881053003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881053003/40001
Message was sent while issue was closed.
Description was changed from ========== This change enables GPU Raster on OSX. I've compiled a bit of benchmark data to support turning this on - https://docs.google.com/a/google.com/document/d/1RPEnillJOaOKW47t9DYuttQkvWDo... Still filling in more data, but I'm pretty happy with the results so far. In a number of cases we have a performance win, and in most cases we have a power win. Checking this in now will give us a long canary period before the next branch point to catch any issues. BUG=542959 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== This change enables GPU Raster on OSX. I've compiled a bit of benchmark data to support turning this on - https://docs.google.com/a/google.com/document/d/1RPEnillJOaOKW47t9DYuttQkvWDo... Still filling in more data, but I'm pretty happy with the results so far. In a number of cases we have a performance win, and in most cases we have a power win. Checking this in now will give us a long canary period before the next branch point to catch any issues. BUG=542959 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== This change enables GPU Raster on OSX. I've compiled a bit of benchmark data to support turning this on - https://docs.google.com/a/google.com/document/d/1RPEnillJOaOKW47t9DYuttQkvWDo... Still filling in more data, but I'm pretty happy with the results so far. In a number of cases we have a performance win, and in most cases we have a power win. Checking this in now will give us a long canary period before the next branch point to catch any issues. BUG=542959 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== This change enables GPU Raster on OSX. I've compiled a bit of benchmark data to support turning this on - https://docs.google.com/a/google.com/document/d/1RPEnillJOaOKW47t9DYuttQkvWDo... Still filling in more data, but I'm pretty happy with the results so far. In a number of cases we have a performance win, and in most cases we have a power win. Checking this in now will give us a long canary period before the next branch point to catch any issues. BUG=542959 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/dc7207cc95e97078afea95e5084ea81a284f5d29 Cr-Commit-Position: refs/heads/master@{#391204} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/dc7207cc95e97078afea95e5084ea81a284f5d29 Cr-Commit-Position: refs/heads/master@{#391204}
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1945653002/ by mathp@chromium.org. The reason for reverting is: Failures on all webkit mac bots: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds....
Message was sent while issue was closed.
Description was changed from ========== This change enables GPU Raster on OSX. I've compiled a bit of benchmark data to support turning this on - https://docs.google.com/a/google.com/document/d/1RPEnillJOaOKW47t9DYuttQkvWDo... Still filling in more data, but I'm pretty happy with the results so far. In a number of cases we have a performance win, and in most cases we have a power win. Checking this in now will give us a long canary period before the next branch point to catch any issues. BUG=542959 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/dc7207cc95e97078afea95e5084ea81a284f5d29 Cr-Commit-Position: refs/heads/master@{#391204} ========== to ========== This change enables GPU Raster on OSX. I've compiled a bit of benchmark data to support turning this on - https://docs.google.com/a/google.com/document/d/1RPEnillJOaOKW47t9DYuttQkvWDo... Still filling in more data, but I'm pretty happy with the results so far. In a number of cases we have a performance win, and in most cases we have a power win. Checking this in now will give us a long canary period before the next branch point to catch any issues. BUG=542959 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/dc7207cc95e97078afea95e5084ea81a284f5d29 Cr-Commit-Position: refs/heads/master@{#391204} ==========
Description was changed from ========== This change enables GPU Raster on OSX. I've compiled a bit of benchmark data to support turning this on - https://docs.google.com/a/google.com/document/d/1RPEnillJOaOKW47t9DYuttQkvWDo... Still filling in more data, but I'm pretty happy with the results so far. In a number of cases we have a performance win, and in most cases we have a power win. Checking this in now will give us a long canary period before the next branch point to catch any issues. BUG=542959 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/dc7207cc95e97078afea95e5084ea81a284f5d29 Cr-Commit-Position: refs/heads/master@{#391204} ========== to ========== This change enables GPU Raster on OSX. I've compiled a bit of benchmark data to support turning this on - https://docs.google.com/a/google.com/document/d/1RPEnillJOaOKW47t9DYuttQkvWDo... Still filling in more data, but I'm pretty happy with the results so far. In a number of cases we have a performance win, and in most cases we have a power win. Checking this in now will give us a long canary period before the next branch point to catch any issues. BUG=542959 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.blink:mac_blink_rel ==========
Patchset #7 (id:200001) has been deleted
Patchset #6 (id:180001) has been deleted
Patchset #5 (id:160001) has been deleted
The CQ bit was checked by ericrk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881053003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881053003/140001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ericrk@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from vmiura@chromium.org, piman@chromium.org Link to the patchset: https://codereview.chromium.org/1881053003/#ps140001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881053003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881053003/140001
Message was sent while issue was closed.
Description was changed from ========== This change enables GPU Raster on OSX. I've compiled a bit of benchmark data to support turning this on - https://docs.google.com/a/google.com/document/d/1RPEnillJOaOKW47t9DYuttQkvWDo... Still filling in more data, but I'm pretty happy with the results so far. In a number of cases we have a performance win, and in most cases we have a power win. Checking this in now will give us a long canary period before the next branch point to catch any issues. BUG=542959 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.blink:mac_blink_rel ========== to ========== This change enables GPU Raster on OSX. I've compiled a bit of benchmark data to support turning this on - https://docs.google.com/a/google.com/document/d/1RPEnillJOaOKW47t9DYuttQkvWDo... Still filling in more data, but I'm pretty happy with the results so far. In a number of cases we have a performance win, and in most cases we have a power win. Checking this in now will give us a long canary period before the next branch point to catch any issues. BUG=542959 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.blink:mac_blink_rel ==========
Message was sent while issue was closed.
Committed patchset #4 (id:140001)
Message was sent while issue was closed.
Description was changed from ========== This change enables GPU Raster on OSX. I've compiled a bit of benchmark data to support turning this on - https://docs.google.com/a/google.com/document/d/1RPEnillJOaOKW47t9DYuttQkvWDo... Still filling in more data, but I'm pretty happy with the results so far. In a number of cases we have a performance win, and in most cases we have a power win. Checking this in now will give us a long canary period before the next branch point to catch any issues. BUG=542959 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.blink:mac_blink_rel ========== to ========== This change enables GPU Raster on OSX. I've compiled a bit of benchmark data to support turning this on - https://docs.google.com/a/google.com/document/d/1RPEnillJOaOKW47t9DYuttQkvWDo... Still filling in more data, but I'm pretty happy with the results so far. In a number of cases we have a performance win, and in most cases we have a power win. Checking this in now will give us a long canary period before the next branch point to catch any issues. BUG=542959 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.blink:mac_blink_rel Committed: https://crrev.com/8325892c2efdef8cff86ba16e7569f8b424daeda Cr-Commit-Position: refs/heads/master@{#391655} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/8325892c2efdef8cff86ba16e7569f8b424daeda Cr-Commit-Position: refs/heads/master@{#391655}
Message was sent while issue was closed.
this CL is causing stability regressions on OS X and I think we should revert, and place GPU raster behind stability finch. Please comment on this plan?
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:140001) has been created in https://codereview.chromium.org/1984183002/ by wfh@chromium.org. The reason for reverting is: Causing stability issues on OS X, please put behind a finch. BUG=610544,608566,610971,609612.
Message was sent while issue was closed.
On Tue, May 17, 2016 at 2:40 AM, <wfh@chromium.org> wrote: > this CL is causing stability regressions on OS X and I think we should > revert, > and place GPU raster behind stability finch. Please comment on this plan? > FYI, you're not going to get an answer between 2:40 am and 2:51 am PDT. The plan always was and still is to launch via finch. > > https://codereview.chromium.org/1881053003/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
