Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 1881043005: install-build-deps: fix syntax error (Closed)

Created:
4 years, 8 months ago by Elly Fong-Jones
Modified:
4 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

install-build-deps: fix syntax error If you run this script on an unsupported platform, you get: are currently supported: command not found BUG= Committed: https://crrev.com/bc90a3e5e6cf04d92dd57300f0d26b1aa0cbbe96 Cr-Commit-Position: refs/heads/master@{#387093}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/install-build-deps.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Elly Fong-Jones
thakis: ptal? :)
4 years, 8 months ago (2016-04-13 20:28:47 UTC) #3
Nico
lgtm This easily wins the "saddest CL of the week" award, jeez.
4 years, 8 months ago (2016-04-13 20:33:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881043005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881043005/1
4 years, 8 months ago (2016-04-13 20:41:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 21:17:18 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 21:18:50 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc90a3e5e6cf04d92dd57300f0d26b1aa0cbbe96
Cr-Commit-Position: refs/heads/master@{#387093}

Powered by Google App Engine
This is Rietveld 408576698