Cleanup IFPF_* interfaces.

Cleanup IFPF_* interfaces.

This CL removes the IFPF_DeviceModule, IFPF_FontMgr and IFPF_Font interfaces
in favour of their concrete classes.

BUG=pdfium:467
Committed: https://pdfium.googlesource.com/pdfium/+/6d8e981b51458f0381031fe240f5215db9906622

[dsinclair, 2016-04-13 14:23:40]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-04-13 14:23:41]

PTAL.

[Tom Sepez, 2016-04-13 17:22:08]

OK, but we really need to ping the android folks about picking up recent
releases and building them, filing bugs when it fails.  Have they been doing
this?

LGTM with nit otherwise.

https://codereview.chromium.org/1881043004/diff/1/core/fxge/android/fpf_skiaf...
File core/fxge/android/fpf_skiafont.cpp (right):

https://codereview.chromium.org/1881043004/diff/1/core/fxge/android/fpf_skiaf...
core/fxge/android/fpf_skiafont.cpp:196: break;
nit: I really like the breaks written the way they were ... saves a line and
ensures the break will be hit if someone somdacy chages line 193 to 
  case FPF_SKIAFONTTYPE_Path: if (somecondition) {

[dsinclair, 2016-04-13 17:51:45]

On 2016/04/13 17:22:08, Tom Sepez wrote:
> OK, but we really need to ping the android folks about picking up recent
> releases and building them, filing bugs when it fails.  Have they been doing
> this?
> 

I'll see if I can figure out the status of Android Bots.


> LGTM with nit otherwise.
> 
>
https://codereview.chromium.org/1881043004/diff/1/core/fxge/android/fpf_skiaf...
> File core/fxge/android/fpf_skiafont.cpp (right):
> 
>
https://codereview.chromium.org/1881043004/diff/1/core/fxge/android/fpf_skiaf...
> core/fxge/android/fpf_skiafont.cpp:196: break;
> nit: I really like the breaks written the way they were ... saves a line and
> ensures the break will be hit if someone somdacy chages line 193 to 
>   case FPF_SKIAFONTTYPE_Path: if (somecondition) {


Going to defer to the style guide on this one and leave as break; }

[dsinclair, 2016-04-13 17:51:50]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-04-13 17:52:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1881043004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1881043004/1

[commit-bot: I haz the power, 2016-04-13 17:52:14]

Description was changed from

==========
Cleanup IFPF_* interfaces.

This CL removes the IFPF_DeviceModule, IFPF_FontMgr and IFPF_Font interfaces
in favour of their concrete classes.

BUG=pdfium:467
==========

to

==========
Cleanup IFPF_* interfaces.

This CL removes the IFPF_DeviceModule, IFPF_FontMgr and IFPF_Font interfaces
in favour of their concrete classes.

BUG=pdfium:467

Committed:
https://pdfium.googlesource.com/pdfium/+/6d8e981b51458f0381031fe240f5215db990...
==========

[commit-bot: I haz the power, 2016-04-13 17:52:15]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/6d8e981b51458f0381031fe240f5215db990...