Delete the font cache file.

chrome/browser/chrome_browser_main_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_browser_main_win.h"
 
 #include <windows.h>
 #include <shellapi.h>
 #include <stddef.h>
 
@@ skipping 62 matching lines @@
 #if BUILDFLAG(ENABLE_KASKO)
 #include "syzygy/kasko/api/reporter.h"
 #endif
 
 namespace {
 
 typedef HRESULT (STDAPICALLTYPE* RegisterApplicationRestartProc)(
     const wchar_t* command_line,
     DWORD flags);
 
+const char kFontCacheSharedSectionName[] = "ChromeDWriteFontCache";
+
 void InitializeWindowProcExceptions() {
   // Get the breakpad pointer from chrome.exe
   base::win::WinProcExceptionFilter exception_filter =
       reinterpret_cast<base::win::WinProcExceptionFilter>(
           ::GetProcAddress(::GetModuleHandle(
                                chrome::kBrowserProcessExecutableName),
                            "CrashForException"));
   exception_filter = base::win::SetWinProcExceptionFilter(exception_filter);
   DCHECK(!exception_filter);
 }
@@ skipping 102 matching lines @@
 
   // Look for the DLLs used to implement the FTH and other compat hacks.
   if (GetModuleHandleW(L"AcLayers.dll") != NULL)
     detected = static_cast<FTHFlags>(detected | FTH_ACLAYERS_LOADED);
   if (GetModuleHandleW(L"AcXtrnal.dll") != NULL)
     detected = static_cast<FTHFlags>(detected | FTH_ACXTRNAL_LOADED);
 
   UMA_HISTOGRAM_ENUMERATION("FaultTolerantHeap", detected, FTH_FLAGS_COUNT);
 }
 
+void DeleteDirectWriteFontCache(base::FilePath path) {
+  // TODO(kulshin): delete this function and associated code in 2017.
+  // Attempt to delete the font cache and ignore any errors.
+  base::DeleteFile(path, false /*recursive*/);

[gab, 2016/04/14 15:04:29]

Define

static const char kFontCacheSharedSectionName[] = "ChromeDWriteFontCache";

locally in this method instead.

[gab, 2016/04/14 15:04:29]

Use kFontCacheSharedSectionName directly here instead of binding the path
(otherwise you might as well just Bind DeleteFile(kFontCacheSharedSectionName,
false) -- I do prefer having the custom method but without |path| param since
it's always constant)

[Ilya Kulshin, 2016/04/14 21:55:37]

Unfortunately I still need the path, since I need the profile directory. I can't
really make this a member since this code runs on a different thread, so I
switched to binding DeleteFile directly. I have no objections to switching back
to a helper function with a |path| parameter if you prefer that instead.

[Ilya Kulshin, 2016/04/14 21:55:37]

Inlined the string constant altogether, since it was used in only one place.

+}
+
 }  // namespace
 
 void ShowCloseBrowserFirstMessageBox() {
   int message_id = IDS_UNINSTALL_CLOSE_APP;
   if (base::win::GetVersion() >= base::win::VERSION_WIN8 &&
       (shell_integration::GetDefaultBrowser() ==
        shell_integration::IS_DEFAULT)) {
     message_id = IDS_UNINSTALL_CLOSE_APP_IMMERSIVE;
   }
   chrome::ShowWarningMessageBox(NULL,
@@ skipping 90 matching lines @@
 
 void ChromeBrowserMainPartsWin::ShowMissingLocaleMessageBox() {
   ui::MessageBox(NULL,
                  base::ASCIIToUTF16(chrome_browser::kMissingLocaleDataMessage),
                  base::ASCIIToUTF16(chrome_browser::kMissingLocaleDataTitle),
                  MB_OK | MB_ICONERROR | MB_TOPMOST);
 }
 
 void ChromeBrowserMainPartsWin::PostProfileInit() {
   ChromeBrowserMainParts::PostProfileInit();
+
+  base::FilePath path(
+      profile()->GetPath().AppendASCII(kFontCacheSharedSectionName));
+  const int kBuildFontCacheDelaySec = 30;
+  content::BrowserThread::PostDelayedTask(

[gab, 2016/04/14 15:04:29]

Use BrowserThread::PostAfterStartupTask() instead of an arbitrary delay.

[Ilya Kulshin, 2016/04/14 21:55:37]

Done.

+      content::BrowserThread::FILE, FROM_HERE,
+      base::Bind(DeleteDirectWriteFontCache, path),
+      base::TimeDelta::FromSeconds(kBuildFontCacheDelaySec));
 }
 
 void ChromeBrowserMainPartsWin::PostBrowserStart() {
   ChromeBrowserMainParts::PostBrowserStart();
 
   UMA_HISTOGRAM_BOOLEAN("Windows.Tablet", base::win::IsTabletDevice(nullptr));
 
   // Set up a task to verify installed modules in the current process.
   content::BrowserThread::PostAfterStartupTask(
       FROM_HERE, content::BrowserThread::GetBlockingPool(),
@@ skipping 186 matching lines @@
   if (resource_id)
     return l10n_util::GetStringUTF16(resource_id);
   return base::string16();
 }
 
 // static
 void ChromeBrowserMainPartsWin::SetupInstallerUtilStrings() {
   CR_DEFINE_STATIC_LOCAL(TranslationDelegate, delegate, ());
   installer::SetTranslationDelegate(&delegate);
 }