Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1881033003: Decouple buffer_queue_unittest from content (Closed)

Created:
4 years, 8 months ago by Fady Samuel
Modified:
4 years, 8 months ago
Reviewers:
jbauman, piman
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Decouple buffer_queue_unittest from content Remove dependencies on GpuSurfacelessBrowserCompositorOutputSurface and BrowserGpuMemoryBufferManager in buffer_queue_unittest to allow it to be refactored out of content/ BUG=601867 Committed: https://crrev.com/0498c8521eeff1478192f1645d49243acec7ee7e Cr-Commit-Position: refs/heads/master@{#387148}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -16 lines) Patch
M content/browser/compositor/buffer_queue_unittest.cc View 10 chunks +14 lines, -16 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Fady Samuel
+piman@ for review. +rjkroege@: FYI
4 years, 8 months ago (2016-04-12 22:53:07 UTC) #3
Fady Samuel
Gentle ping
4 years, 8 months ago (2016-04-13 16:10:01 UTC) #4
jbauman
lgtm
4 years, 8 months ago (2016-04-13 22:33:25 UTC) #6
Fady Samuel
Thanks! CQ'ing
4 years, 8 months ago (2016-04-13 22:43:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881033003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881033003/1
4 years, 8 months ago (2016-04-13 22:43:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 23:40:09 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 23:41:24 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0498c8521eeff1478192f1645d49243acec7ee7e
Cr-Commit-Position: refs/heads/master@{#387148}

Powered by Google App Engine
This is Rietveld 408576698