components/rappor/byte_vector_utils.h - Issue 188103004: C++ Readability review for holte

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/rappor/byte_vector_utils.h

Issue 188103004: C++ Readability review for holte (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/rappor/byte_vector_utils.h

diff --git a/components/rappor/byte_vector_utils.h b/components/rappor/byte_vector_utils.h

index 9154cab75a96fcaa50beeda5e32ff49c4ba3ea09..0e3304131eafc8a04b1e3200d7f9be39f13186e3 100644

--- a/components/rappor/byte_vector_utils.h

+++ b/components/rappor/byte_vector_utils.h

@@ -8,6 +8,7 @@

#include <vector>

#include "base/basictypes.h"

+#include "base/macros.h"

#include "components/rappor/rappor_parameters.h"

#include "crypto/hmac.h"