components/rappor/rappor_service_unittest.cc - Issue 188103004: C++ Readability review for holte

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/rappor/rappor_service_unittest.cc

Issue 188103004: C++ Readability review for holte (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

	5 // Change for readability

	6

5 #include "components/rappor/rappor_service.h"	7 #include "components/rappor/rappor_service.h"

6	8

7 #include "testing/gtest/include/gtest/gtest.h"	9 #include "testing/gtest/include/gtest/gtest.h"

8	10

9 namespace rappor {	11 namespace rappor {

10	12

11 class TestRapporService : public RapporService {	13 class TestRapporService : public RapporService {

12 public:	14 public:

13 void GetReports(RapporReports* reports) {	15 void GetReports(RapporReports* reports) {

14 ExportMetrics(reports);	16 ExportMetrics(reports);

(...skipping 26 matching lines...) Expand all Loading...
41 RapporReports reports;	43 RapporReports reports;

42 rappor_service.GetReports(&reports);	44 rappor_service.GetReports(&reports);

43 EXPECT_EQ(1, reports.report_size());	45 EXPECT_EQ(1, reports.report_size());

44	46

45 const RapporReports::Report& report = reports.report(0);	47 const RapporReports::Report& report = reports.report(0);

46 EXPECT_TRUE(report.name_hash());	48 EXPECT_TRUE(report.name_hash());

47 EXPECT_EQ(16u, report.bits().size());	49 EXPECT_EQ(16u, report.bits().size());

48 }	50 }

49	51

50 } // namespace rappor	52 } // namespace rappor

OLD	NEW