C++ Readability review for holte

components/rappor/log_uploader.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+// Change for readability
+
 #include "components/rappor/log_uploader.h"
 
 #include "base/metrics/histogram.h"
 #include "base/metrics/sparse_histogram.h"
 #include "net/base/load_flags.h"
 #include "net/url_request/url_fetcher.h"
 
 namespace {
 
 // The delay, in seconds, between uploading when there are queued logs to send.
@@ skipping 80 matching lines @@
   return interval > max_interval ? max_interval : interval;
 }
 
 void LogUploader::OnURLFetchComplete(const net::URLFetcher* source) {
   // We're not allowed to re-use the existing |URLFetcher|s, so free them here.
   // Note however that |source| is aliased to the fetcher, so we should be
   // careful not to delete it too early.
   DCHECK_EQ(current_fetch_.get(), source);
   scoped_ptr<net::URLFetcher> fetch(current_fetch_.Pass());
 
   int response_code = source->GetResponseCode();

[ktl, 2014/03/18 08:35:01]

This variable (and upload_succeeded and server_is_healthy) can be const. While
marking locals as const can help the compiler, it's a benefit for the reader who
doesn't have to scan the code to see if there's a later assignment to it.

[Steven Holte, 2014/03/19 23:46:55]

Done.

 
   // Log a histogram to track response success vs. failure rates.
   UMA_HISTOGRAM_SPARSE_SLOWLY("Rappor.UploadResponseCode", response_code);
 
   bool upload_succeeded = response_code == 200;
 
   // Determine whether this log should be retransmitted.
   DiscardReason reason = NUM_DISCARD_REASONS;
   if (upload_succeeded) {
     reason = UPLOAD_SUCCESS;
@@ skipping 24 matching lines @@
   if (!server_is_healthy)
     upload_interval_ = BackOffUploadInterval(upload_interval_);
   else
     upload_interval_ = base::TimeDelta::FromSeconds(kUnsentLogsIntervalSeconds);
 
   if (more_logs_remaining)
     ScheduleNextUpload(upload_interval_);
 }
 
 }  // namespace rappor