Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1881013004: Convert pdf/ to use std::unique_ptr. (Closed)

Created:
4 years, 8 months ago by Lei Zhang
Modified:
4 years, 8 months ago
Reviewers:
dcheng
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert pdf/ to use std::unique_ptr. BUG=554298 Committed: https://crrev.com/79ce717c93677da7d3db074bad0349995980ce93 Cr-Commit-Position: refs/heads/master@{#386857}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M pdf/out_of_process_instance.h View 5 chunks +6 lines, -6 lines 0 comments Download
M pdf/pdfium/pdfium_engine.h View 2 chunks +2 lines, -2 lines 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M pdf/pdfium/pdfium_page.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Lei Zhang
4 years, 8 months ago (2016-04-12 22:21:28 UTC) #2
dcheng
lgtm
4 years, 8 months ago (2016-04-12 22:53:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881013004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881013004/1
4 years, 8 months ago (2016-04-12 23:00:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 23:24:05 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 23:25:09 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/79ce717c93677da7d3db074bad0349995980ce93
Cr-Commit-Position: refs/heads/master@{#386857}

Powered by Google App Engine
This is Rietveld 408576698