pkg/compiler/lib/src/cps_ir/inline.dart - Issue 1881013002: Expand ResolvedAst to handle synthetic constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/cps_ir/inline.dart

Issue 1881013002: Expand ResolvedAst to handle synthetic constructors. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Updated cf. comments + fix test, cps and compilation units for injected members. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/cps_ir/inline.dart

diff --git a/pkg/compiler/lib/src/cps_ir/inline.dart b/pkg/compiler/lib/src/cps_ir/inline.dart

index cbb673dfe95a055ccd552111c7020af3f9e59048..5a004212d2ea90122d7172df3cfbce15172dbdf4 100644

--- a/pkg/compiler/lib/src/cps_ir/inline.dart

+++ b/pkg/compiler/lib/src/cps_ir/inline.dart

@@ -211,7 +211,8 @@ class Inliner implements Pass {

// Do not inline in functions containing try statements. V8 does not

// optimize code in such functions, so inlining will move optimizable code

// into a context where it cannot be optimized.

- if (function.resolvedAst.elements.containsTryStatement) {

+ if (function.resolvedAst.kind == ResolvedAstKind.PARSED &&

+ function.resolvedAst.elements.containsTryStatement) {

return;

}