Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart

Issue 1881013002: Expand ResolvedAst to handle synthetic constructors. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Turn comment into TODO. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
index e9d184537a00b13cbc03b1fe5f58118f5d0b10e2..54cb1adc8d129bca3d8ae559d32498a38e822111 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
@@ -193,7 +193,7 @@ class IrBuilderVisitor extends ast.Visitor<ir.Primitive>
/// one currently being built.
ClosureScope getClosureScopeForFunction(FunctionElement function) {
closure.ClosureClassMap map = compiler.closureToClassMapper
- .computeClosureToClassMapping(function, function.node, elements);
+ .computeClosureToClassMapping(function.resolvedAst);
return new ClosureScope(map.capturingScopes[function.node]);
}
@@ -714,7 +714,7 @@ class IrBuilderVisitor extends ast.Visitor<ir.Primitive>
ConstructorElement constructor = body.constructor;
ast.FunctionExpression node = constructor.node;
closureClassMap = compiler.closureToClassMapper
- .computeClosureToClassMapping(constructor, node, elements);
+ .computeClosureToClassMapping(constructor.resolvedAst);
// We compute variables boxed in mutable variables on entry to each try
// block, not including variables captured by a closure (which are boxed
@@ -745,7 +745,7 @@ class IrBuilderVisitor extends ast.Visitor<ir.Primitive>
assert(elements[node] != null);
closureClassMap = compiler.closureToClassMapper
- .computeClosureToClassMapping(element, node, elements);
+ .computeClosureToClassMapping(element.resolvedAst);
TryBoxedVariables variables = _analyzeTryBoxedVariables(node);
tryStatements = variables.tryStatements;
IrBuilder builder = getBuilderFor(element);
@@ -758,7 +758,7 @@ class IrBuilderVisitor extends ast.Visitor<ir.Primitive>
return null; // Nothing to do.
}
closureClassMap = compiler.closureToClassMapper
- .computeClosureToClassMapping(element, element.node, elements);
+ .computeClosureToClassMapping(element.resolvedAst);
IrBuilder builder = getBuilderFor(element);
return withBuilder(builder, () {
irBuilder.buildFunctionHeader(<Local>[]);

Powered by Google App Engine
This is Rietveld 408576698