Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1881013002: Expand ResolvedAst to handle synthetic constructors. (Closed)

Created:
4 years, 8 months ago by Johnni Winther
Modified:
4 years, 8 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Expand ResolvedAst to handle synthetic constructors. Main change is to add [ResolvedAstKind] to support ResolvedAst for default and forwarding constructors. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/7e8e01610e3b4e7f99ebb7d849ebbea38c8cf05e

Patch Set 1 #

Patch Set 2 : dartfmt #

Total comments: 1

Patch Set 3 : Turn comment into TODO. #

Total comments: 4

Patch Set 4 : Updated cf. comments + fix test, cps and compilation units for injected members. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+631 lines, -212 lines) Patch
M pkg/compiler/lib/src/closure.dart View 1 4 chunks +12 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/common/backend_api.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/common/codegen.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/compile_time_constants.dart View 1 3 chunks +8 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 7 chunks +15 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 2 3 10 chunks +15 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/inline.dart View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 2 chunks +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +60 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 2 3 10 chunks +170 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/id_generator.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_visitor.dart View 1 3 chunks +6 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 1 4 chunks +17 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 1 3 chunks +9 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/enum_creator.dart View 1 chunk +23 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/operators.dart View 1 2 chunks +30 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 chunk +6 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/serialization/element_serialization.dart View 1 2 3 5 chunks +19 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/serialization/equivalence.dart View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 1 2 3 2 chunks +11 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart View 1 5 chunks +37 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/serialization/serialization.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 15 chunks +77 lines, -55 lines 0 comments Download
M tests/compiler/dart2js/analyze_dart2js_helpers_test.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/related_types.dart View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/serialization_helper.dart View 5 chunks +83 lines, -11 lines 0 comments Download
M tests/compiler/dart2js/serialization_model_test.dart View 2 chunks +6 lines, -30 lines 0 comments Download
M tests/compiler/dart2js/serialization_test.dart View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/serialization_test_helper.dart View 1 2 3 2 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Johnni Winther
https://codereview.chromium.org/1881013002/diff/20001/pkg/compiler/lib/src/elements/modelx.dart File pkg/compiler/lib/src/elements/modelx.dart (right): https://codereview.chromium.org/1881013002/diff/20001/pkg/compiler/lib/src/elements/modelx.dart#newcode2707 pkg/compiler/lib/src/elements/modelx.dart:2707: /// This element is used to encode an enum ...
4 years, 8 months ago (2016-04-12 13:59:19 UTC) #3
Siggi Cherem (dart-lang)
lgtm! https://codereview.chromium.org/1881013002/diff/40001/pkg/compiler/lib/src/elements/modelx.dart File pkg/compiler/lib/src/elements/modelx.dart (right): https://codereview.chromium.org/1881013002/diff/40001/pkg/compiler/lib/src/elements/modelx.dart#newcode2358 pkg/compiler/lib/src/elements/modelx.dart:2358: bool get hasResolvedAst => true; by now do ...
4 years, 8 months ago (2016-04-12 17:52:57 UTC) #4
Johnni Winther
https://codereview.chromium.org/1881013002/diff/40001/pkg/compiler/lib/src/elements/modelx.dart File pkg/compiler/lib/src/elements/modelx.dart (right): https://codereview.chromium.org/1881013002/diff/40001/pkg/compiler/lib/src/elements/modelx.dart#newcode2358 pkg/compiler/lib/src/elements/modelx.dart:2358: bool get hasResolvedAst => true; On 2016/04/12 17:52:57, Siggi ...
4 years, 8 months ago (2016-04-13 10:18:12 UTC) #5
Johnni Winther
Committed patchset #4 (id:60001) manually as 7e8e01610e3b4e7f99ebb7d849ebbea38c8cf05e (presubmit successful).
4 years, 8 months ago (2016-04-13 10:45:25 UTC) #7
Johnni Winther
Committed but PTAL at the last patch.
4 years, 8 months ago (2016-04-13 11:06:55 UTC) #8
Siggi Cherem (dart-lang)
4 years, 8 months ago (2016-04-13 15:57:28 UTC) #9
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698