[stubs] Introduce LeftShift, SignedRightShift and UnsignedRightShift stubs.

[stubs] Introduce LeftShift, SignedRightShift and UnsignedRightShift stubs.

Add the stubs for JavaScript's '<<', '>>' and '>>>' operators and lets Ignition make use of them in the respective bytecode handlers.

Committed: https://crrev.com/599369d6b8e1a5ccdca857def06eebcbacf47dd4
Cr-Commit-Position: refs/heads/master@{#35433}

Committed: https://crrev.com/a5f6daab41dedf766d66ef85859a456e325765bf
Cr-Commit-Position: refs/heads/master@{#35446}

[epertoso, 2016-04-12 12:41:45]

epertoso@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2016-04-12 12:55:20]

LGTM with nit. And please rename to match TF/Ignition operators and hook it up
with TF as well.

https://codereview.chromium.org/1881003002/diff/1/src/code-stubs.cc
File src/code-stubs.cc (right):

https://codereview.chromium.org/1881003002/diff/1/src/code-stubs.cc#newcode1591
src/code-stubs.cc:1591: Label if_smi_overflow(assembler, Label::kDeferred),
Nit: Can you wrap this into ChangeUint32ToTagged?

[epertoso, 2016-04-12 15:10:16]

The CQ bit was checked by epertoso@chromium.org

[epertoso, 2016-04-12 15:10:16]

Renamed the stubs.

https://codereview.chromium.org/1881003002/diff/1/src/code-stubs.cc
File src/code-stubs.cc (right):

https://codereview.chromium.org/1881003002/diff/1/src/code-stubs.cc#newcode1591
src/code-stubs.cc:1591: Label if_smi_overflow(assembler, Label::kDeferred),
On 2016/04/12 at 12:55:20, Benedikt Meurer wrote:
> Nit: Can you wrap this into ChangeUint32ToTagged?

Sure.

[epertoso, 2016-04-12 15:10:17]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1881003002/#ps20001
(title: "Update")

[commit-bot: I haz the power, 2016-04-12 15:10:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1881003002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1881003002/20001

[commit-bot: I haz the power, 2016-04-12 15:12:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-12 15:12:54]

Try jobs failed on following builders:
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)

[epertoso, 2016-04-13 08:29:26]

The CQ bit was checked by epertoso@chromium.org

[epertoso, 2016-04-13 08:29:26]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1881003002/#ps40001
(title: "Rebased.")

[commit-bot: I haz the power, 2016-04-13 08:29:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1881003002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1881003002/40001

[commit-bot: I haz the power, 2016-04-13 08:53:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-13 08:55:27]

Description was changed from

==========
[stubs] Introduce LeftShift, SignedRightShift and UnsignedRightShift stubs.

Add the stubs for JavaScript's '<<', '>>' and '>>>' operators and lets Ignition
make use of them in the respective bytecode handlers.
==========

to

==========
[stubs] Introduce LeftShift, SignedRightShift and UnsignedRightShift stubs.

Add the stubs for JavaScript's '<<', '>>' and '>>>' operators and lets Ignition
make use of them in the respective bytecode handlers.

Committed: https://crrev.com/599369d6b8e1a5ccdca857def06eebcbacf47dd4
Cr-Commit-Position: refs/heads/master@{#35433}
==========

[commit-bot: I haz the power, 2016-04-13 08:55:28]

Patchset 3 (id:??) landed as
https://crrev.com/599369d6b8e1a5ccdca857def06eebcbacf47dd4
Cr-Commit-Position: refs/heads/master@{#35433}

[Michael Achenbach, 2016-04-13 12:10:35]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1880413002/ by machenbach@chromium.org.

The reason for reverting is: Needed to revert
https://codereview.chromium.org/1617503003.

[epertoso, 2016-04-13 13:08:32]

The CQ bit was checked by epertoso@chromium.org

[epertoso, 2016-04-13 13:08:32]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1881003002/#ps60001
(title: "Update after rollback")

[commit-bot: I haz the power, 2016-04-13 13:08:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1881003002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1881003002/60001

[commit-bot: I haz the power, 2016-04-13 13:51:34]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-13 13:53:10]

Description was changed from

==========
[stubs] Introduce LeftShift, SignedRightShift and UnsignedRightShift stubs.

Add the stubs for JavaScript's '<<', '>>' and '>>>' operators and lets Ignition
make use of them in the respective bytecode handlers.

Committed: https://crrev.com/599369d6b8e1a5ccdca857def06eebcbacf47dd4
Cr-Commit-Position: refs/heads/master@{#35433}
==========

to

==========
[stubs] Introduce LeftShift, SignedRightShift and UnsignedRightShift stubs.

Add the stubs for JavaScript's '<<', '>>' and '>>>' operators and lets Ignition
make use of them in the respective bytecode handlers.

Committed: https://crrev.com/599369d6b8e1a5ccdca857def06eebcbacf47dd4
Cr-Commit-Position: refs/heads/master@{#35433}

Committed: https://crrev.com/a5f6daab41dedf766d66ef85859a456e325765bf
Cr-Commit-Position: refs/heads/master@{#35446}
==========

[commit-bot: I haz the power, 2016-04-13 13:53:11]

Patchset 4 (id:??) landed as
https://crrev.com/a5f6daab41dedf766d66ef85859a456e325765bf
Cr-Commit-Position: refs/heads/master@{#35446}