Issue 18810: Close the handle to the child process after terminating it. This avoids...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18810: Close the handle to the child process after terminating it. This avoids... (Closed)

Created:
11 years, 11 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Close the handle to the child process after terminating it. This avoids calling RegisterWaitForSingleObject with a handle to a process that has already been terminated. (See the use of ProcessWatcher in the destructor of BrowserRenderProcessHost.) I'm not sure that this explains why RWFSO fails, but it seems like a reasonable change anyways. The MSDN docs do not give any reasons for why RWFSO might fail. R=maruel BUG=3782 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8651

Patch Set 1 #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/renderer_host/browser_render_process_host.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages