extensions/browser/extension_function.cc - Issue 1880933002: Begin to enable extension APIs in Extension Service Worker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/extension_function.cc

Issue 1880933002: Begin to enable extension APIs in Extension Service Worker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments -> round 1 Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/extensions/api_test/service_worker/tabs_create/sw.js ('K') | « content/renderer/service_worker/service_worker_context_client.cc ('k') | extensions/browser/extension_function_dispatcher.h » ('j') | extensions/browser/extension_function_dispatcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/extension_function.cc

diff --git a/extensions/browser/extension_function.cc b/extensions/browser/extension_function.cc

index b11621fa96e4f3a7d2d57e75ec829f9db0ee22b9..53de37b13d36e434459cf8a24c276243ad87c81b 100644

--- a/extensions/browser/extension_function.cc

+++ b/extensions/browser/extension_function.cc

@@ -441,6 +441,9 @@ UIThreadExtensionFunction::render_view_host_do_not_use() const {

void UIThreadExtensionFunction::SetRenderFrameHost(

content::RenderFrameHost* render_frame_host) {

+ // An extension function from Service Worker does not have a RenderFrameHost.

+ if (!render_frame_host)

+ return;

DCHECK_NE(render_frame_host_ == nullptr, render_frame_host == nullptr);

render_frame_host_ = render_frame_host;

tracker_.reset(