content/renderer/service_worker/service_worker_context_client.cc - Issue 1880933002: Begin to enable extension APIs in Extension Service Worker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/service_worker/service_worker_context_client.cc

Issue 1880933002: Begin to enable extension APIs in Extension Service Worker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments from Daniel Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/renderer/content_renderer_client.h ('k') | extensions/browser/extension_function.cc » ('j') | third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/service_worker/service_worker_context_client.cc

diff --git a/content/renderer/service_worker/service_worker_context_client.cc b/content/renderer/service_worker/service_worker_context_client.cc

index bc480484d70d53ccc02c33ad9664b63b9ddf6ed2..0caeaf6c5d499815953c496429b4acc683bd9b2f 100644

--- a/content/renderer/service_worker/service_worker_context_client.cc

+++ b/content/renderer/service_worker/service_worker_context_client.cc

@@ -406,7 +406,8 @@ void ServiceWorkerContextClient::didInitializeWorkerContext(

v8::Local<v8::Context> context) {

GetContentClient()

->renderer()

- ->DidInitializeServiceWorkerContextOnWorkerThread(context, script_url_);

+ ->DidInitializeServiceWorkerContextOnWorkerThread(

+ context, embedded_worker_id_, script_url_);

}

void ServiceWorkerContextClient::willDestroyWorkerContext(

@@ -425,7 +426,7 @@ void ServiceWorkerContextClient::willDestroyWorkerContext(

g_worker_client_tls.Pointer()->Set(NULL);

GetContentClient()->renderer()->WillDestroyServiceWorkerContextOnWorkerThread(

- context, script_url_);

+ context, embedded_worker_id_, script_url_);

}

void ServiceWorkerContextClient::workerContextDestroyed() {