Begin to enable extension APIs in Extension Service Worker.

third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp

 /*
  * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "bindings/core/v8/WorkerOrWorkletScriptController.h"
 
 #include "bindings/core/v8/ScriptCallStack.h"
+#include "bindings/core/v8/ScriptController.h"
 #include "bindings/core/v8/ScriptSourceCode.h"
 #include "bindings/core/v8/ScriptValue.h"
 #include "bindings/core/v8/V8DedicatedWorkerGlobalScope.h"
 #include "bindings/core/v8/V8ErrorHandler.h"
 #include "bindings/core/v8/V8Initializer.h"
 #include "bindings/core/v8/V8ObjectConstructor.h"
 #include "bindings/core/v8/V8ScriptRunner.h"
 #include "bindings/core/v8/V8SharedWorkerGlobalScope.h"
 #include "bindings/core/v8/V8WorkerGlobalScope.h"
 #include "bindings/core/v8/WrapperTypeInfo.h"
@@ skipping 114 matching lines @@
     // Create a new v8::Context with the worker/worklet as the global object
     // (aka the inner global).
     ScriptWrappable* scriptWrappable = m_globalScope->getScriptWrappable();
     const WrapperTypeInfo* wrapperTypeInfo = scriptWrappable->wrapperTypeInfo();
     v8::Local<v8::FunctionTemplate> globalInterfaceTemplate = wrapperTypeInfo->domTemplate(m_isolate, *m_world);
     if (globalInterfaceTemplate.IsEmpty())
         return false;
     v8::Local<v8::ObjectTemplate> globalTemplate = globalInterfaceTemplate->InstanceTemplate();
     v8::Local<v8::Context> context;
     {
+        // Initialize V8 extensions before creating the context.
+        Vector<const char*> extensionNames;
+        if (m_globalScope->isServiceWorkerGlobalScope()) {
+            // TODO(lazyboy): Should we add V8Extensions to all service worker
+            // contexts, when we actually don't care about them in non extension
+            // service worker contexts?
+            const V8Extensions& extensions = ScriptController::registeredExtensions();

[haraken, 2016/04/22 18:33:21]

Nit: Now it doesn't make sense to put the registered extensions on
ScriptController since they are used by WorkerOrWorkletScriptController as well.
Maybe we should move them to V8Initializer.

(You don't need to address the issue in this CL.)

[lazyboy, 2016/04/22 20:45:19]

OK, I'll move it in a separate CL, I've also fixed the todo above to check
whether this worker's url is an extension URL or not, through Platform.

+            extensionNames.reserveInitialCapacity(extensions.size());
+            for (const auto* extension : extensions)
+                extensionNames.append(extension->name());
+        }
+        v8::ExtensionConfiguration extensionConfiguration(extensionNames.size(), extensionNames.data());
+
         V8PerIsolateData::UseCounterDisabledScope useCounterDisabled(V8PerIsolateData::from(m_isolate));
-        context = v8::Context::New(m_isolate, nullptr, globalTemplate);
+        context = v8::Context::New(m_isolate, &extensionConfiguration, globalTemplate);
     }
     if (context.IsEmpty())
         return false;
 
     m_scriptState = ScriptState::create(context, m_world);
 
     ScriptState::Scope scope(m_scriptState.get());
 
     // Name new context for debugging. For main thread worklet global scopes
     // this is done once the context is initialized.
@@ skipping 139 matching lines @@
         m_executionState->m_errorEventFromImportedScript = errorEvent;
     exceptionState.rethrowV8Exception(V8ThrowException::createGeneralError(m_isolate, errorMessage));
 }
 
 DEFINE_TRACE(WorkerOrWorkletScriptController)
 {
     visitor->trace(m_globalScope);
 }
 
 } // namespace blink