Begin to enable extension APIs in Extension Service Worker.

third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp

 /*
  * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "bindings/core/v8/WorkerOrWorkletScriptController.h"
 
 #include "bindings/core/v8/ScriptCallStack.h"
+#include "bindings/core/v8/ScriptController.h"
 #include "bindings/core/v8/ScriptSourceCode.h"
 #include "bindings/core/v8/ScriptValue.h"
 #include "bindings/core/v8/V8DedicatedWorkerGlobalScope.h"
 #include "bindings/core/v8/V8ErrorHandler.h"
 #include "bindings/core/v8/V8Initializer.h"
 #include "bindings/core/v8/V8ObjectConstructor.h"
 #include "bindings/core/v8/V8ScriptRunner.h"
 #include "bindings/core/v8/V8SharedWorkerGlobalScope.h"
 #include "bindings/core/v8/V8WorkerGlobalScope.h"
 #include "bindings/core/v8/WrapperTypeInfo.h"
 #include "core/events/ErrorEvent.h"
 #include "core/frame/DOMTimer.h"
 #include "core/inspector/MainThreadDebugger.h"
 #include "core/inspector/WorkerThreadDebugger.h"
 #include "core/workers/MainThreadWorkletGlobalScope.h"
 #include "core/workers/WorkerOrWorkletGlobalScope.h"
 #include "core/workers/WorkerThread.h"
 #include "platform/heap/ThreadState.h"
 #include "public/platform/Platform.h"
+#include "wtf/Threading.h"
 #include <v8.h>
 
 namespace blink {
 
 class WorkerOrWorkletScriptController::ExecutionState final {
     STACK_ALLOCATED();
 public:
     explicit ExecutionState(WorkerOrWorkletScriptController* controller)
         : hadException(false)
         , lineNumber(0)
@@ skipping 36 matching lines @@
     // and its fields will be traced when scanning the stack.
     Member<WorkerOrWorkletScriptController> m_controller;
     ExecutionState* m_outerState;
 };
 
 WorkerOrWorkletScriptController* WorkerOrWorkletScriptController::create(WorkerOrWorkletGlobalScope* globalScope, v8::Isolate* isolate)
 {
     return new WorkerOrWorkletScriptController(globalScope, isolate);
 }
 
+V8Extensions& WorkerOrWorkletScriptController::registeredExtensions()
+{
+    // Accessed from worker threads.
+    DEFINE_THREAD_SAFE_STATIC_LOCAL(V8Extensions, extensions, new V8Extensions);
+    return extensions;
+}
+
+void WorkerOrWorkletScriptController::registerExtensionIfNeeded(v8::Extension* extension)
+{
+    const V8Extensions& extensions = registeredExtensions();
+    for (size_t i = 0; i < extensions.size(); ++i) {
+        if (extensions[i] == extension)
+            return;
+    }
+    v8::RegisterExtension(extension);

[yhirano, 2016/04/22 02:28:11]

Naive question, is this function thread-safe?

[lazyboy, 2016/04/22 03:25:25]

Good question, It seems this would eventually call
RegisteredExtension::Register() in v8, which seems to build some kind of link
between |extension|.

I've got rid of this though after haraken@'s suggestion.

+    registeredExtensions().append(extension);
+}
+
 WorkerOrWorkletScriptController::WorkerOrWorkletScriptController(WorkerOrWorkletGlobalScope* globalScope, v8::Isolate* isolate)
     : m_globalScope(globalScope)
     , m_isolate(isolate)
     , m_executionForbidden(false)
     , m_executionScheduledToTerminate(false)
     , m_rejectedPromises(RejectedPromises::create())
     , m_executionState(0)
 {
     ASSERT(isolate);
     m_world = DOMWrapperWorld::create(isolate, WorkerWorldId);
@@ skipping 39 matching lines @@
     // Create a new v8::Context with the worker/worklet as the global object
     // (aka the inner global).
     ScriptWrappable* scriptWrappable = m_globalScope->getScriptWrappable();
     const WrapperTypeInfo* wrapperTypeInfo = scriptWrappable->wrapperTypeInfo();
     v8::Local<v8::FunctionTemplate> globalInterfaceTemplate = wrapperTypeInfo->domTemplate(m_isolate, *m_world);
     if (globalInterfaceTemplate.IsEmpty())
         return false;
     v8::Local<v8::ObjectTemplate> globalTemplate = globalInterfaceTemplate->InstanceTemplate();
     v8::Local<v8::Context> context;
     {
+        // Initialize V8 extensions before creating the context.
+        Vector<const char*> extensionNames;
+        if (m_globalScope->isServiceWorkerGlobalScope()) {

[haraken, 2016/04/21 07:50:44]

Slightly better:

  CHECK(m_globalScope->isServiceWorkerGlobalScope() ||
registeredExtensions().size() == 0);

[lazyboy, 2016/04/22 00:17:39]

Since the latest patch uses ScriptController::registeredExtensions(),
registeredExtensions().size can be > 0 for non service worker global scope.

+            const V8Extensions& extensions = registeredExtensions();
+            extensionNames.reserveInitialCapacity(extensions.size());
+            for (const auto* extension : extensions)
+                extensionNames.append(extension->name());
+        }
+        v8::ExtensionConfiguration extensionConfiguration(extensionNames.size(), extensionNames.data());
+
         V8PerIsolateData::UseCounterDisabledScope useCounterDisabled(V8PerIsolateData::from(m_isolate));
-        context = v8::Context::New(m_isolate, nullptr, globalTemplate);
+        context = v8::Context::New(m_isolate, &extensionConfiguration, globalTemplate);
     }
     if (context.IsEmpty())
         return false;
 
     m_scriptState = ScriptState::create(context, m_world);
 
     ScriptState::Scope scope(m_scriptState.get());
 
     // Name new context for debugging. For main thread worklet global scopes
     // this is done once the context is initialized.
@@ skipping 139 matching lines @@
         m_executionState->m_errorEventFromImportedScript = errorEvent;
     exceptionState.rethrowV8Exception(V8ThrowException::createGeneralError(m_isolate, errorMessage));
 }
 
 DEFINE_TRACE(WorkerOrWorkletScriptController)
 {
     visitor->trace(m_globalScope);
 }
 
 } // namespace blink