components/signin/core/browser/fake_signin_manager.h - Issue 1880923003: GetAccountIdFromProfile() should not return an empty account id if a valid profile is provided.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/fake_signin_manager.h

Issue 1880923003: GetAccountIdFromProfile() should not return an empty account id if a valid profile is provided. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replace scoped_ptr with std::unique_ptr Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/ash/multi_user/multi_user_util.cc ('K') | « chrome/chrome_tests_unit.gypi ('k') | components/signin/core/browser/fake_signin_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/signin/core/browser/fake_signin_manager.h

diff --git a/components/signin/core/browser/fake_signin_manager.h b/components/signin/core/browser/fake_signin_manager.h

index 272fe10500bc49928887bc6d2aa7b41cd335536b..83b2728e18957f8725b7f3b7fe47a2593fad7694 100644

--- a/components/signin/core/browser/fake_signin_manager.h

+++ b/components/signin/core/browser/fake_signin_manager.h

@@ -23,6 +23,8 @@ class FakeSigninManagerBase : public SigninManagerBase {

FakeSigninManagerBase(SigninClient* client,

AccountTrackerService* account_tracker_service);

~FakeSigninManagerBase() override;

+ void SignIn(const std::string& account_id);

};

#if !defined(OS_CHROMEOS)

« chrome/browser/ui/ash/multi_user/multi_user_util.cc ('K') | « chrome/chrome_tests_unit.gypi ('k') | components/signin/core/browser/fake_signin_manager.cc » ('j') | no next file with comments »