Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 1880923002: GLContext: Remove WasDirtiedExternally methods (Closed)

Created:
4 years, 8 months ago by ccameron
Modified:
4 years, 8 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GLContext: Remove WasDirtiedExternally methods These aren't used anymore. Remove them to make room for other, different messes. BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/88c94b1a9b97b044490846aacf2c14421dadfd36 Cr-Commit-Position: refs/heads/master@{#387147}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -67 lines) Patch
M gpu/command_buffer/service/gl_context_virtual.h View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gl_context_virtual.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M ui/gl/gl_context.h View 3 chunks +0 lines, -13 lines 0 comments Download
M ui/gl/gl_context.cc View 2 chunks +5 lines, -29 lines 0 comments Download
M ui/gl/gl_gl_api_implementation.cc View 2 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
ccameron
Leaning on the delete key.
4 years, 8 months ago (2016-04-12 03:09:45 UTC) #3
ccameron
ping (nothing but deleted code)
4 years, 8 months ago (2016-04-13 19:34:34 UTC) #4
Zhenyao Mo
lgtm
4 years, 8 months ago (2016-04-13 20:39:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880923002/1
4 years, 8 months ago (2016-04-13 22:14:02 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 23:39:45 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 23:41:22 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88c94b1a9b97b044490846aacf2c14421dadfd36
Cr-Commit-Position: refs/heads/master@{#387147}

Powered by Google App Engine
This is Rietveld 408576698