build/gn_helpers.py - Issue 1880903002: Switch MB to write the GN args to args.gn.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/gn_helpers.py

Issue 1880903002: Switch MB to write the GN args to args.gn. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix_mb_goma

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/gn_helpers.py

diff --git a/build/gn_helpers.py b/build/gn_helpers.py

index 6aeddae5fd853c7e58def9254e5a24a289853710..484ae5af54fe033f5a55f6b8087583fe83e01875 100644

--- a/build/gn_helpers.py

+++ b/build/gn_helpers.py

@@ -51,7 +51,7 @@ def ToGNString(value, allow_dicts = True):

if not allow_dicts:

raise GNException("Attempting to recursively print a dictionary.")

result = ""

- for key in value:

+ for key in sorted(value):

Dirk Pranke 2016/04/12 18:06:49 this makes things a little more deterministic and

if not isinstance(key, str):

raise GNException("Dictionary key is not a string.")

result += "%s = %s\n" % (key, ToGNString(value[key], False))

« no previous file with comments | « no previous file | tools/mb/mb.py » ('j') | no next file with comments »