Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 1880903002: Switch MB to write the GN args to args.gn. (Closed)

Created:
4 years, 8 months ago by Dirk Pranke
Modified:
4 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_mb_goma
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch MB to write the GN args to args.gn. This CL switches MB from passing the gn arguments on the command line via --args to actually writing them to an args.gn file. This makes some of the escaping slightly cleaner and also will enable us to embed import() lines in a follow-on CL, so that we can use //build/args templates. R=brettw@chromium.org BUG=602528 Committed: https://crrev.com/eca4a786d114c8a36583503f3d251a37dcffa023 Cr-Commit-Position: refs/heads/master@{#387205}

Patch Set 1 #

Total comments: 3

Patch Set 2 : fix doc string per review #

Patch Set 3 : fix unicode handling in gn_helpers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -34 lines) Patch
M build/gn_helpers.py View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M tools/mb/mb.py View 1 9 chunks +44 lines, -23 lines 0 comments Download
M tools/mb/mb_unittest.py View 2 chunks +18 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Dirk Pranke
https://codereview.chromium.org/1880903002/diff/1/build/gn_helpers.py File build/gn_helpers.py (right): https://codereview.chromium.org/1880903002/diff/1/build/gn_helpers.py#newcode54 build/gn_helpers.py:54: for key in sorted(value): this makes things a little ...
4 years, 8 months ago (2016-04-12 18:06:49 UTC) #1
brettw
lgtm https://codereview.chromium.org/1880903002/diff/1/build/gn_helpers.py File build/gn_helpers.py (right): https://codereview.chromium.org/1880903002/diff/1/build/gn_helpers.py#newcode27 build/gn_helpers.py:27: """Prints the given value to stdout. While you're ...
4 years, 8 months ago (2016-04-12 21:46:04 UTC) #2
Dirk Pranke
https://codereview.chromium.org/1880903002/diff/1/build/gn_helpers.py File build/gn_helpers.py (right): https://codereview.chromium.org/1880903002/diff/1/build/gn_helpers.py#newcode27 build/gn_helpers.py:27: """Prints the given value to stdout. On 2016/04/12 21:46:03, ...
4 years, 8 months ago (2016-04-12 21:47:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880903002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880903002/20001
4 years, 8 months ago (2016-04-13 19:20:05 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn/builds/18671)
4 years, 8 months ago (2016-04-13 19:27:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880903002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880903002/40001
4 years, 8 months ago (2016-04-14 00:39:36 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-14 01:42:53 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 01:44:23 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/eca4a786d114c8a36583503f3d251a37dcffa023
Cr-Commit-Position: refs/heads/master@{#387205}

Powered by Google App Engine
This is Rietveld 408576698