Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1182)

Issue 1880893002: Add TestExpectations for flaky test under --site-per-process (Closed)

Created:
4 years, 8 months ago by Charlie Harrison
Modified:
4 years, 8 months ago
Reviewers:
Łukasz Anforowicz
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add TestExpectations for flaky test under --site-per-process BUG=602421 Committed: https://crrev.com/4dae3aaa783d7a657aaaf9356d9e09e82d329fbb Cr-Commit-Position: refs/heads/master@{#386676}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/site-per-process View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Charlie Harrison
The test is flaky, so I added a [ Pass Failure ] to the expectations. ...
4 years, 8 months ago (2016-04-12 12:38:05 UTC) #2
Łukasz Anforowicz
LGTM, thanks for looking into this.
4 years, 8 months ago (2016-04-12 14:09:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880893002/1
4 years, 8 months ago (2016-04-12 14:10:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 14:16:09 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 14:17:44 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4dae3aaa783d7a657aaaf9356d9e09e82d329fbb
Cr-Commit-Position: refs/heads/master@{#386676}

Powered by Google App Engine
This is Rietveld 408576698