Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1880873002: Revert "Revert of Pass effects directly to fontcache (patchset #8 id:140001 of https://codereview.c… (Closed)

Created:
4 years, 8 months ago by reed1
Modified:
4 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert "Revert of Pass effects directly to fontcache (patchset #8 id:140001 of https://codereview.chromium.org/1863013003/ )" add SK_SUPPORT_NEW_ONCREATESCALERCONTEXT for chrome this has now landed https://codereview.chromium.org/1878913002/ TBR= BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1880873002 Committed: https://skia.googlesource.com/skia/+/a9322c2d86aaef1085c267dfc43cf0747f170a86

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -169 lines) Patch
M include/core/SkPaint.h View 3 chunks +5 lines, -2 lines 0 comments Download
M include/core/SkTypeface.h View 5 chunks +6 lines, -4 lines 0 comments Download
M src/core/SkGlyphCache.h View 3 chunks +7 lines, -5 lines 0 comments Download
M src/core/SkGlyphCache.cpp View 2 chunks +6 lines, -5 lines 0 comments Download
M src/core/SkPaint.cpp View 6 chunks +16 lines, -11 lines 0 comments Download
M src/core/SkScalerContext.h View 4 chunks +20 lines, -8 lines 0 comments Download
M src/core/SkScalerContext.cpp View 7 chunks +18 lines, -37 lines 0 comments Download
M src/core/SkTypeface.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M src/fonts/SkGScalerContext.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/fonts/SkGScalerContext.cpp View 3 chunks +36 lines, -40 lines 0 comments Download
M src/fonts/SkRandomScalerContext.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/fonts/SkRandomScalerContext.cpp View 3 chunks +10 lines, -7 lines 0 comments Download
M src/fonts/SkTestScalerContext.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/fonts/SkTestScalerContext.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M src/gpu/GrPathRendering.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrPathRendering.cpp View 4 chunks +9 lines, -4 lines 0 comments Download
M src/gpu/GrResourceProvider.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrResourceProvider.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M src/gpu/text/GrAtlasTextBlob.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/text/GrAtlasTextBlob.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/text/GrAtlasTextBlob_regenInBatch.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/text/GrStencilAndCoverTextContext.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M src/gpu/text/GrTextUtils.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M src/ports/SkFontHost_FreeType.cpp View 3 chunks +8 lines, -6 lines 0 comments Download
M src/ports/SkFontHost_FreeType_common.h View 2 chunks +5 lines, -4 lines 0 comments Download
M src/ports/SkFontHost_mac.cpp View 4 chunks +8 lines, -5 lines 0 comments Download
M src/ports/SkFontHost_win.cpp View 4 chunks +10 lines, -6 lines 0 comments Download
M src/ports/SkScalerContext_win_dw.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkScalerContext_win_dw.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/ports/SkTypeface_win_dw.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/ports/SkTypeface_win_dw.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/FontMgrTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
reed1
4 years, 8 months ago (2016-04-12 02:02:13 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880873002/1
4 years, 8 months ago (2016-04-12 02:02:31 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-12 02:41:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880873002/1
4 years, 8 months ago (2016-04-12 13:42:55 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 13:47:09 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a9322c2d86aaef1085c267dfc43cf0747f170a86

Powered by Google App Engine
This is Rietveld 408576698