Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Unified Diff: chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm

Issue 1880853002: Convert ValidationMessageBubbleView to BubbleDialogDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: compile Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm b/chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm
index 65932a292f83f10a7945ef1444a660c87c2343ea..74f89cdb49e57857be4965c5335f64a1b7b536f4 100644
--- a/chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm
+++ b/chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm
@@ -167,12 +167,15 @@ ValidationMessageBubbleCocoa::ValidationMessageBubbleCocoa(
subText:sub_text] retain]);
}
-ValidationMessageBubbleCocoa::~ValidationMessageBubbleCocoa() {
- [controller_ close];
-}
+ValidationMessageBubbleCocoa::~ValidationMessageBubbleCocoa() {}
void ValidationMessageBubbleCocoa::SetPositionRelativeToAnchor(
content::RenderWidgetHost* widget_host,
const gfx::Rect& anchor_in_root_view) {
[controller_ setAnchorPoint:GetAnchorPoint(widget_host, anchor_in_root_view)];
}
+
+ValidationMessageBubbleCocoa::CloseValidationMessage() {
groby-ooo-7-16 2016/04/14 00:37:53 Ooops. Missed this. Please add "void" :)
Evan Stade 2016/04/18 01:16:43 Done. Thanks.
+ [controller_ close];
+ delete this;
+}

Powered by Google App Engine
This is Rietveld 408576698