Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8943)

Unified Diff: chrome/browser/ui/views/tab_dialogs_views.cc

Issue 1880853002: Convert ValidationMessageBubbleView to BubbleDialogDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: msw review Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/tab_dialogs_views.cc
diff --git a/chrome/browser/ui/views/tab_dialogs_views.cc b/chrome/browser/ui/views/tab_dialogs_views.cc
index 617fcff98aece80e8ffb1359eb368ded8f7d4f37..a00eead8482edb877cc4be0169182959ef67def0 100644
--- a/chrome/browser/ui/views/tab_dialogs_views.cc
+++ b/chrome/browser/ui/views/tab_dialogs_views.cc
@@ -74,10 +74,10 @@ void TabDialogsViews::HideManagePasswordsBubble() {
ManagePasswordsBubbleView::CloseCurrentBubble();
}
-std::unique_ptr<ValidationMessageBubble> TabDialogsViews::ShowValidationMessage(
+base::WeakPtr<ValidationMessageBubble> TabDialogsViews::ShowValidationMessage(
const gfx::Rect& anchor_in_root_view,
const base::string16& main_text,
const base::string16& sub_text) {
- return base::WrapUnique(new ValidationMessageBubbleView(
- web_contents_, anchor_in_root_view, main_text, sub_text));
+ return (new ValidationMessageBubbleView(
+ web_contents_, anchor_in_root_view, main_text, sub_text))->AsWeakPtr();
}
« no previous file with comments | « chrome/browser/ui/views/tab_dialogs_views.h ('k') | chrome/browser/ui/views/validation_message_bubble_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698