chrome/browser/ui/tab_dialogs.h - Issue 1880853002: Convert ValidationMessageBubbleView to BubbleDialogDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tab_dialogs.h

Issue 1880853002: Convert ValidationMessageBubbleView to BubbleDialogDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: msw review Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/validation_message_bubble_controller_unittest.mm ('k') | chrome/browser/ui/validation_message_bubble.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/tab_dialogs.h

diff --git a/chrome/browser/ui/tab_dialogs.h b/chrome/browser/ui/tab_dialogs.h

index c7ad9b7d160bd8ad3ee0306b18c6b89e9ba46ede..ef0f8a984cd6af6e252d8e66a1fb672ea7e7aa12 100644

--- a/chrome/browser/ui/tab_dialogs.h

+++ b/chrome/browser/ui/tab_dialogs.h

@@ -8,6 +8,7 @@

#include <memory>

#include <string>

+#include "base/memory/weak_ptr.h"

#include "base/strings/string16.h"

#include "base/supports_user_data.h"

#include "chrome/browser/ui/validation_message_bubble.h"

@@ -63,7 +64,7 @@ class TabDialogs : public base::SupportsUserData::Data {

virtual void ShowManagePasswordsBubble(bool user_action) = 0;

virtual void HideManagePasswordsBubble() = 0;

- virtual std::unique_ptr<ValidationMessageBubble> ShowValidationMessage(

+ virtual base::WeakPtr<ValidationMessageBubble> ShowValidationMessage(

const gfx::Rect& anchor_in_root_view,

const base::string16& main_text,

const base::string16& sub_text) = 0;