chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm - Issue 1880853002: Convert ValidationMessageBubbleView to BubbleDialogDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm

Issue 1880853002: Convert ValidationMessageBubbleView to BubbleDialogDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: msw review Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/validation_message_bubble_cocoa.h ('k') | chrome/browser/ui/cocoa/validation_message_bubble_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm b/chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm

index 65932a292f83f10a7945ef1444a660c87c2343ea..f5e58920f125ca7c9b748644b71bd82801ad6ae9 100644

--- a/chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm

+++ b/chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm

@@ -167,12 +167,15 @@ ValidationMessageBubbleCocoa::ValidationMessageBubbleCocoa(

subText:sub_text] retain]);

}

-ValidationMessageBubbleCocoa::~ValidationMessageBubbleCocoa() {

- [controller_ close];

+ValidationMessageBubbleCocoa::~ValidationMessageBubbleCocoa() {}

void ValidationMessageBubbleCocoa::SetPositionRelativeToAnchor(

content::RenderWidgetHost* widget_host,

const gfx::Rect& anchor_in_root_view) {

[controller_ setAnchorPoint:GetAnchorPoint(widget_host, anchor_in_root_view)];

}

+void ValidationMessageBubbleCocoa::CloseValidationMessage() {

+ [controller_ close];

+ delete this;