Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Unified Diff: chrome/browser/ui/views/validation_message_bubble_delegate_unittest.cc

Issue 1880853002: Convert ValidationMessageBubbleView to BubbleDialogDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: msw review Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/validation_message_bubble_delegate_unittest.cc
diff --git a/chrome/browser/ui/views/validation_message_bubble_delegate_unittest.cc b/chrome/browser/ui/views/validation_message_bubble_delegate_unittest.cc
deleted file mode 100644
index 3b562dd69da81b036ca912282be4dcb85436a050..0000000000000000000000000000000000000000
--- a/chrome/browser/ui/views/validation_message_bubble_delegate_unittest.cc
+++ /dev/null
@@ -1,52 +0,0 @@
-// Copyright (c) 2013 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/ui/views/validation_message_bubble_delegate.h"
-
-#include "base/strings/utf_string_conversions.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-namespace {
-
-gfx::Size GetSizeForMessages(const std::string& main_text,
- const std::string& sub_text) {
- ValidationMessageBubbleDelegate delegate(
- gfx::Rect(), base::UTF8ToUTF16(main_text),
- base::UTF8ToUTF16(sub_text), NULL);
- return delegate.GetPreferredSize();
-}
-
-TEST(ValidationMessageBubbleDelegate, Size) {
- gfx::Size short_main_empty_sub_size = GetSizeForMessages("foo", "");
- EXPECT_LE(ValidationMessageBubbleDelegate::kWindowMinWidth,
- short_main_empty_sub_size.width());
- EXPECT_LE(0, short_main_empty_sub_size.height());
-
- gfx::Size long_main_empty_sub_size = GetSizeForMessages(
- "Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod"
- " tempor incididunt ut labore et dolore magna aliqua.", "");
- EXPECT_GE(ValidationMessageBubbleDelegate::kWindowMaxWidth,
- long_main_empty_sub_size.width());
- EXPECT_GT(long_main_empty_sub_size.height(),
- short_main_empty_sub_size.height());
-
- gfx::Size short_main_medium_sub_size =
- GetSizeForMessages("foo", "foo bar baz");
- EXPECT_GT(short_main_medium_sub_size.width(),
- short_main_empty_sub_size.width());
- EXPECT_GT(short_main_medium_sub_size.height(),
- short_main_empty_sub_size.height());
-
- gfx::Size short_main_long_sub_size = GetSizeForMessages("foo",
- "Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod"
- " tempor incididunt ut labore et dolore magna aliqua.");
- EXPECT_GT(short_main_long_sub_size.width(),
- short_main_medium_sub_size.width());
- EXPECT_GE(ValidationMessageBubbleDelegate::kWindowMaxWidth,
- short_main_long_sub_size.width());
- EXPECT_GT(short_main_long_sub_size.height(),
- short_main_medium_sub_size.height());
-}
-
-}

Powered by Google App Engine
This is Rietveld 408576698