Convert ValidationMessageBubbleView to BubbleDialogDelegate

chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/validation_message_bubble_cocoa.h"
 
 #include <memory>
 
 #include "base/mac/foundation_util.h"
 #include "base/strings/sys_string_conversions.h"
@@ skipping 149 matching lines @@
     const base::string16& sub_text) {
   content::RenderWidgetHost* widget_host =
       web_contents->GetRenderViewHost()->GetWidget();
   controller_.reset([[[ValidationMessageBubbleController alloc]
             init:[widget_host->GetView()->GetNativeView() window]
       anchoredAt:GetAnchorPoint(widget_host, anchor_in_root_view)
         mainText:main_text
          subText:sub_text] retain]);
 }
 
-ValidationMessageBubbleCocoa::~ValidationMessageBubbleCocoa() {
-  [controller_ close];
-}
+ValidationMessageBubbleCocoa::~ValidationMessageBubbleCocoa() {}
 
 void ValidationMessageBubbleCocoa::SetPositionRelativeToAnchor(
     content::RenderWidgetHost* widget_host,
     const gfx::Rect& anchor_in_root_view) {
   [controller_ setAnchorPoint:GetAnchorPoint(widget_host, anchor_in_root_view)];
 }
+
+ValidationMessageBubbleCococa::CloseValidationMessage() {
+  [controller_ close];
+  delete this;

[groby-ooo-7-16, 2016/04/13 01:42:31]

I'm not a fan of self-deletion. Do we have to?

[Evan Stade, 2016/04/13 15:39:19]

I had to make it a WeakPtr (bubble is self-owning) to make ownership simpler and
more orthodox on Views. In general bubbles usually own themselves.
ConfirmBubbleController on cocoa is an example (if I'm understanding it
correctly). Should this be [self autorelease]; instead of delete this?

[groby-ooo-7-16, 2016/04/13 21:05:56]

No, [self autorelease] is an Objective C thing. I just don't like delete this,
but if it's consistent, fine...

+}