chrome/browser/ui/cocoa/validation_message_bubble_controller_unittest.mm - Issue 1880853002: Convert ValidationMessageBubbleView to BubbleDialogDelegate

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/validation_message_bubble_controller_unittest.mm

Issue 1880853002: Convert ValidationMessageBubbleView to BubbleDialogDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: msw review Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm ('k') | chrome/browser/ui/tab_dialogs.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #import <Cocoa/Cocoa.h>	5 #import <Cocoa/Cocoa.h>

6	6

7 #include "base/strings/utf_string_conversions.h"	7 #include "base/strings/utf_string_conversions.h"

8 #import "chrome/browser/ui/cocoa/validation_message_bubble_controller.h"	8 #import "chrome/browser/ui/cocoa/validation_message_bubble_controller.h"

9 #include "testing/gtest/include/gtest/gtest.h"	9 #include "testing/gtest/include/gtest/gtest.h"

10	10

(...skipping 22 matching lines...) Expand all Loading...
33 EXPECT_GT(NSHeight(shortMainMediumSubFrame), NSHeight(shortMainNoSubFrame));	33 EXPECT_GT(NSHeight(shortMainMediumSubFrame), NSHeight(shortMainNoSubFrame));

34	34

35 NSRect shortMainLongSubFrame = [constructView("abc",	35 NSRect shortMainLongSubFrame = [constructView("abc",

36 "Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod"	36 "Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod"

37 " tempor incididunt ut labore et dolore magna aliqua.") frame];	37 " tempor incididunt ut labore et dolore magna aliqua.") frame];

38 EXPECT_GT(NSWidth(shortMainLongSubFrame), NSWidth(shortMainMediumSubFrame));	38 EXPECT_GT(NSWidth(shortMainLongSubFrame), NSWidth(shortMainMediumSubFrame));

39 EXPECT_LT(NSWidth(shortMainLongSubFrame), 500);	39 EXPECT_LT(NSWidth(shortMainLongSubFrame), 500);

40 EXPECT_GT(NSHeight(shortMainLongSubFrame), NSHeight(shortMainMediumSubFrame));	40 EXPECT_GT(NSHeight(shortMainLongSubFrame), NSHeight(shortMainMediumSubFrame));

41 }	41 }

42	42

43 }	43 } // namespace

44

OLD	NEW