Dartium support for manual custom element upgrades.

Dartium support for manual custom element upgrades.

This is the Dartium portion of https://codereview.chromium.org/177113014/

BUG=
R=jmesserly@google.com, vsm@google.com

Committed: https://src.chromium.org/viewvc/multivm/branches/1650/blink?view=rev&revision=171887

[Jennifer Messerly, 2014-03-06 23:44:34]

fwiw, LGTM :)

[vsm, 2014-03-07 00:05:39]

On 2014/03/06 23:44:34, John Messerly wrote:
> fwiw, LGTM :)

Can you re-upload?  The diffs aren't showing up.

[Jennifer Messerly, 2014-03-07 00:15:23]

On 2014/03/07 00:05:39, vsm wrote:
> On 2014/03/06 23:44:34, John Messerly wrote:
> > fwiw, LGTM :)
> 
> Can you re-upload?  The diffs aren't showing up.

yeah, side by side is busted but you can see by clicking on "unified diff"

[Jennifer Messerly, 2014-04-04 01:39:36]

I see the other side of this (https://codereview.chromium.org/177113014/)
landed, does this CL still need to land too?

[blois, 2014-04-16 20:44:04]

Re-updated, and the Dart side has landed (and stuck!).

[vsm, 2014-04-16 21:33:05]

https://chromiumcodereview.appspot.com/188083002/diff/20001/Source/bindings/d...
File Source/bindings/dart/DartCustomElementWrapper.h (right):

https://chromiumcodereview.appspot.com/188083002/diff/20001/Source/bindings/d...
Source/bindings/dart/DartCustomElementWrapper.h:52: static Dart_Handle
swapElementWrapper(DartDOMData*, HTMLElement*, Dart_Handle wrapperType, intptr_t
nativeClassId);
Can this be private?

https://chromiumcodereview.appspot.com/188083002/diff/20001/Source/bindings/d...
File Source/bindings/dart/DartNativeUtilities.cpp (right):

https://chromiumcodereview.appspot.com/188083002/diff/20001/Source/bindings/d...
Source/bindings/dart/DartNativeUtilities.cpp:251: if (!Dart_IsType(wrapperType))
{
How do we validate that this is an allowable type wrt to the element?

[blois, 2014-04-16 22:18:50]

https://chromiumcodereview.appspot.com/188083002/diff/20001/Source/bindings/d...
File Source/bindings/dart/DartCustomElementWrapper.h (right):

https://chromiumcodereview.appspot.com/188083002/diff/20001/Source/bindings/d...
Source/bindings/dart/DartCustomElementWrapper.h:52: static Dart_Handle
swapElementWrapper(DartDOMData*, HTMLElement*, Dart_Handle wrapperType, intptr_t
nativeClassId);
On 2014/04/16 21:33:05, vsm wrote:
> Can this be private?

Done.

https://chromiumcodereview.appspot.com/188083002/diff/20001/Source/bindings/d...
File Source/bindings/dart/DartNativeUtilities.cpp (right):

https://chromiumcodereview.appspot.com/188083002/diff/20001/Source/bindings/d...
Source/bindings/dart/DartNativeUtilities.cpp:251: if (!Dart_IsType(wrapperType))
{
On 2014/04/16 21:33:05, vsm wrote:
> How do we validate that this is an allowable type wrt to the element?  

Much of the code is shared with the custom element registration-
https://codereview.chromium.org/177113014/diff/40001/tools/dom/src/dartium_Cu...

Primary check is that the upgrader has a known native type which can be upgraded
and the runtimeType of the element being upgraded has to match (not just be
assignable).

In addition the native class ID is reused from the original wrapper to the new
wrapper, so the native type cannot change even while the wrapper changes.

[vsm, 2014-04-16 22:26:51]

lgtm

[blois, 2014-04-17 20:30:23]

Committed patchset #3 manually as r171887 (presubmit successful).