Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4215)

Unified Diff: base/metrics/sparse_histogram.h

Issue 1880803003: Display histograms from subprocesses in chrome://histograms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/metrics/sparse_histogram.h
diff --git a/base/metrics/sparse_histogram.h b/base/metrics/sparse_histogram.h
index c0723715a46581c27381e9f434ea99766b8c4d4c..08f069f985175bb989b51bf785a9f2fe57204b75 100644
--- a/base/metrics/sparse_histogram.h
+++ b/base/metrics/sparse_histogram.h
@@ -81,8 +81,10 @@ class BASE_EXPORT SparseHistogram : public HistogramBase {
bool AddSamplesFromPickle(base::PickleIterator* iter) override;
std::unique_ptr<HistogramSamples> SnapshotSamples() const override;
std::unique_ptr<HistogramSamples> SnapshotDelta() override;
- void WriteHTMLGraph(std::string* output) const override;
- void WriteAscii(std::string* output) const override;
+ void WriteHTMLGraph(const HistogramSamples* snapshot,
+ std::string* output) const override;
+ void WriteAscii(const HistogramSamples* snapshot,
+ std::string* output) const override;
protected:
// HistogramBase implementation:
@@ -109,6 +111,7 @@ class BASE_EXPORT SparseHistogram : public HistogramBase {
// Helpers for emitting Ascii graphic. Each method appends data to output.
void WriteAsciiImpl(bool graph_it,
const std::string& newline,
+ const HistogramSamples* snapshot,
std::string* output) const;
// Write a common header message describing this histogram.

Powered by Google App Engine
This is Rietveld 408576698