Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 188073002: Added pixel test that ensures WebGL content can render properly after a context loss and restore. (Closed)

Created:
6 years, 9 months ago by bajones
Modified:
6 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, piman+watch_chromium.org, jam, darin-cc_chromium.org, chrishtr
Visibility:
Public.

Description

Added pixel test that ensures WebGL content can render properly after a context loss and restore. Tests a regression introduced by http://src.chromium.org/viewvc/blink?revision=167860&view=revision BUG=349195 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256126

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -3 lines) Patch
A + content/test/data/gpu/pixel_webgl_context_restore.html View 3 chunks +25 lines, -3 lines 0 comments Download
M content/test/gpu/page_sets/pixel_tests.json View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
bajones
kbr@: PTAL chrishtr@: FYI
6 years, 9 months ago (2014-03-05 22:05:38 UTC) #1
Ken Russell (switch to Gerrit)
Very very nice. LGTM
6 years, 9 months ago (2014-03-05 22:09:16 UTC) #2
Ken Russell (switch to Gerrit)
By the way, I think you are going to run into a problem where this ...
6 years, 9 months ago (2014-03-05 22:10:03 UTC) #3
ojan
I'm not familiar with the webgl tests in general...is there a reason this can't be ...
6 years, 9 months ago (2014-03-06 00:33:58 UTC) #4
bajones
The CQ bit was checked by bajones@chromium.org
6 years, 9 months ago (2014-03-10 22:27:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bajones@chromium.org/188073002/1
6 years, 9 months ago (2014-03-10 23:07:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bajones@chromium.org/188073002/1
6 years, 9 months ago (2014-03-10 23:59:55 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-11 04:13:34 UTC) #8
Message was sent while issue was closed.
Change committed as 256126

Powered by Google App Engine
This is Rietveld 408576698