Register IME extension after loading it succesfully.

Register IME extension after loading it succesfully.

IME component is loaded by InputMethodManagerImpl::LoadNecessaryComponentExtensions(), which bypass the default extension loading path ComponentLoader::AddDefaultComponentExtensions(), thus it doesn't register itself with ExtensionPrefValueMap and causes the NOTREACHED() error. To solve this, we manually register the IME extension after loading it successfully.

BUG=454513
Committed: https://crrev.com/e64b0adc2383d929181822010194a43a052525e2
Cr-Commit-Position: refs/heads/master@{#386535}

[xdai1, 2016-04-11 22:17:58]

xdai@chromium.org changed reviewers:
+ shuchen@chromium.org

[xdai1, 2016-04-11 22:17:59]

shuchen@, could you help review this CL please? Thanks!

[xdai1, 2016-04-11 22:21:47]

Description was changed from

==========
Register IME extension after loading it succesfully.

IME component loading is loaded by
InputMethodManagerImpl::LoadNecessaryComponentExtensions(), which bypass the
default extension loading path ComponentLoader::AddDefaultComponentExtensions(),
thus it doesn't register itself with ExtensionPrefValueMap and causes the
NOTREACHED() error. To solve this, we manually register the IME extension after
loading it successfully.

BUG=454513
==========

to

==========
Register IME extension after loading it succesfully.

IME component is loaded by
InputMethodManagerImpl::LoadNecessaryComponentExtensions(), which bypass the
default extension loading path ComponentLoader::AddDefaultComponentExtensions(),
thus it doesn't register itself with ExtensionPrefValueMap and causes the
NOTREACHED() error. To solve this, we manually register the IME extension after
loading it successfully.

BUG=454513
==========

[Shu Chen, 2016-04-11 22:38:05]

https://codereview.chromium.org/1880723002/diff/1/chrome/browser/chromeos/inp...
File chrome/browser/chromeos/input_method/input_method_manager_impl.cc (right):

https://codereview.chromium.org/1880723002/diff/1/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/input_method_manager_impl.cc:1072:
std::string extension_id;
Using extension_ime_util::GetExtensionIDFromInputMethodID() with empty string
check to avoid change of the LoadComponentExtensionIME() interface.

https://codereview.chromium.org/1880723002/diff/1/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/input_method_manager_impl.cc:1077:
->RegisterExtension(extension_id,
Suggest to put this close to the actual loading code, e.g. in
ComponentExtensionIMEManagerImpl::Load().

[xdai1, 2016-04-12 00:02:28]

Patchset #2 (id:20001) has been deleted

[xdai1, 2016-04-12 00:04:42]

Please take another look, thanks for your review!

https://codereview.chromium.org/1880723002/diff/1/chrome/browser/chromeos/inp...
File chrome/browser/chromeos/input_method/input_method_manager_impl.cc (right):

https://codereview.chromium.org/1880723002/diff/1/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/input_method_manager_impl.cc:1077:
->RegisterExtension(extension_id,
On 2016/04/11 22:38:05, Shu Chen wrote:
> Suggest to put this close to the actual loading code, e.g. in
> ComponentExtensionIMEManagerImpl::Load().

Might be better to put this in DoLoadExtension() function in
component_extension_ime_manager_impl.cc?

[Shu Chen, 2016-04-12 00:26:08]

lgtm

[xdai1, 2016-04-12 00:41:00]

The CQ bit was checked by xdai@chromium.org

[commit-bot: I haz the power, 2016-04-12 00:41:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1880723002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1880723002/40001

[commit-bot: I haz the power, 2016-04-12 00:58:21]

Description was changed from

==========
Register IME extension after loading it succesfully.

IME component is loaded by
InputMethodManagerImpl::LoadNecessaryComponentExtensions(), which bypass the
default extension loading path ComponentLoader::AddDefaultComponentExtensions(),
thus it doesn't register itself with ExtensionPrefValueMap and causes the
NOTREACHED() error. To solve this, we manually register the IME extension after
loading it successfully.

BUG=454513
==========

to

==========
Register IME extension after loading it succesfully.

IME component is loaded by
InputMethodManagerImpl::LoadNecessaryComponentExtensions(), which bypass the
default extension loading path ComponentLoader::AddDefaultComponentExtensions(),
thus it doesn't register itself with ExtensionPrefValueMap and causes the
NOTREACHED() error. To solve this, we manually register the IME extension after
loading it successfully.

BUG=454513
==========

[commit-bot: I haz the power, 2016-04-12 00:58:22]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-04-12 00:59:28]

Description was changed from

==========
Register IME extension after loading it succesfully.

IME component is loaded by
InputMethodManagerImpl::LoadNecessaryComponentExtensions(), which bypass the
default extension loading path ComponentLoader::AddDefaultComponentExtensions(),
thus it doesn't register itself with ExtensionPrefValueMap and causes the
NOTREACHED() error. To solve this, we manually register the IME extension after
loading it successfully.

BUG=454513
==========

to

==========
Register IME extension after loading it succesfully.

IME component is loaded by
InputMethodManagerImpl::LoadNecessaryComponentExtensions(), which bypass the
default extension loading path ComponentLoader::AddDefaultComponentExtensions(),
thus it doesn't register itself with ExtensionPrefValueMap and causes the
NOTREACHED() error. To solve this, we manually register the IME extension after
loading it successfully.

BUG=454513

Committed: https://crrev.com/e64b0adc2383d929181822010194a43a052525e2
Cr-Commit-Position: refs/heads/master@{#386535}
==========

[commit-bot: I haz the power, 2016-04-12 00:59:29]

Patchset 2 (id:??) landed as
https://crrev.com/e64b0adc2383d929181822010194a43a052525e2
Cr-Commit-Position: refs/heads/master@{#386535}