Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: media/blink/webmediaplayer_impl_unittest.cc

Issue 1880713002: media: Don't idle suspend the pipeline when in fullscreen (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: delete newline Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/blink/webmediaplayer_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/webmediaplayer_impl_unittest.cc
diff --git a/media/blink/webmediaplayer_impl_unittest.cc b/media/blink/webmediaplayer_impl_unittest.cc
index 84f48bade0ac3d878bf2d6b491c509aeffd2b2fa..2e53526c12396b3c6ad44bb5974506ded1752a5e 100644
--- a/media/blink/webmediaplayer_impl_unittest.cc
+++ b/media/blink/webmediaplayer_impl_unittest.cc
@@ -129,6 +129,7 @@ class WebMediaPlayerImplTest : public testing::Test {
void SetPaused(bool is_paused) { wmpi_->paused_ = is_paused; }
void SetSeeking(bool is_seeking) { wmpi_->seeking_ = is_seeking; }
void SetEnded(bool is_ended) { wmpi_->ended_ = is_ended; }
+ void SetFullscreen(bool is_fullscreen) { wmpi_->fullscreen_ = is_fullscreen; }
void SetMetadata(bool has_audio, bool has_video) {
wmpi_->SetNetworkState(blink::WebMediaPlayer::NetworkStateLoaded);
@@ -332,7 +333,20 @@ TEST_F(WebMediaPlayerImplTest, ComputePlayState_Paused_Seek) {
SetSeeking(true);
state = ComputePlayState();
- EXPECT_EQ(WebMediaPlayerImpl::DelegateState::PAUSED_SEEK,
+ EXPECT_EQ(WebMediaPlayerImpl::DelegateState::PAUSED_BUT_NOT_IDLE,
+ state.delegate_state);
+ EXPECT_FALSE(state.is_memory_reporting_enabled);
+ EXPECT_FALSE(state.is_suspended);
+}
+
+TEST_F(WebMediaPlayerImplTest, ComputePlayState_Paused_Fullscreen) {
+ WebMediaPlayerImpl::PlayState state;
+ SetMetadata(true, true);
+ SetReadyState(blink::WebMediaPlayer::ReadyStateHaveFutureData);
+ SetFullscreen(true);
+
+ state = ComputePlayState();
+ EXPECT_EQ(WebMediaPlayerImpl::DelegateState::PAUSED_BUT_NOT_IDLE,
state.delegate_state);
EXPECT_FALSE(state.is_memory_reporting_enabled);
EXPECT_FALSE(state.is_suspended);
« no previous file with comments | « media/blink/webmediaplayer_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698