Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: runtime/vm/code_generator.cc

Issue 18807007: Fix wrong type test optimization when testing against a signature class: we must always consider th… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/object.cc ('k') | runtime/vm/flow_graph_compiler_arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_generator.cc
===================================================================
--- runtime/vm/code_generator.cc (revision 24952)
+++ runtime/vm/code_generator.cc (working copy)
@@ -533,29 +533,30 @@
&malformed_error);
ASSERT(malformed_error.IsNull()); // Malformed types are not optimized.
}
- OS::PrintErr(" Updated test cache %p ix: %"Pd" with (%"Pd", %p, %p, %s)\n"
- " [%p %s %"Pd", %p %s]\n"
- " [%p %s %"Pd", %p %s] %s\n",
+ OS::PrintErr(" Updated test cache %p ix: %"Pd" with "
+ "(cid: %"Pd", type-args: %p, instantiator: %p, result: %s)\n"
+ " instance [class: (%p '%s' cid: %"Pd"), type-args: %p %s]\n"
+ " test-type [class: (%p '%s' cid: %"Pd"), in-type-args: %p %s]\n",
new_cache.raw(),
len,
+
instance_class.id(),
-
instance_type_arguments.raw(),
instantiator_type_arguments.raw(),
result.ToCString(),
instance_class.raw(),
- instance_class.ToCString(),
+ String::Handle(instance_class.Name()).ToCString(),
instance_class.id(),
instance_type_arguments.raw(),
instance_type_arguments.ToCString(),
test_type.type_class(),
- Class::Handle(test_type.type_class()).ToCString(),
+ String::Handle(Class::Handle(test_type.type_class()).Name()).
+ ToCString(),
Class::Handle(test_type.type_class()).id(),
instantiator_type_arguments.raw(),
- instantiator_type_arguments.ToCString(),
- result.ToCString());
+ instantiator_type_arguments.ToCString());
}
}
« no previous file with comments | « runtime/lib/object.cc ('k') | runtime/vm/flow_graph_compiler_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698