Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm

Issue 1880693002: Desktop Capture Picker New UI: Preliminary Refactor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nit Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm
diff --git a/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm b/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm
index 7c03f91a69d56d4182cafbdbaad3f05577f7c68f..964d9dd06d1d14ec36255c502c691e433e35199a 100644
--- a/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm
+++ b/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm
@@ -10,6 +10,7 @@
#include "base/command_line.h"
#import "base/mac/bundle_locations.h"
#include "base/strings/sys_string_conversions.h"
+#include "chrome/browser/media/combined_desktop_media_list.h"
#import "chrome/browser/ui/cocoa/key_equivalent_constants.h"
#import "chrome/browser/ui/cocoa/media_picker/desktop_media_picker_item.h"
#include "chrome/common/chrome_switches.h"
@@ -63,12 +64,14 @@ const int kExcessButtonPadding = 6;
@implementation DesktopMediaPickerController
-- (id)initWithMediaList:(std::unique_ptr<DesktopMediaList>)media_list
- parent:(NSWindow*)parent
- callback:(const DesktopMediaPicker::DoneCallback&)callback
- appName:(const base::string16&)appName
- targetName:(const base::string16&)targetName
- requestAudio:(bool)requestAudio {
+- (id)initWithScreenList:(std::unique_ptr<DesktopMediaList>)screen_list
+ windowList:(std::unique_ptr<DesktopMediaList>)window_list
+ tabList:(std::unique_ptr<DesktopMediaList>)tab_list
+ parent:(NSWindow*)parent
+ callback:(const DesktopMediaPicker::DoneCallback&)callback
+ appName:(const base::string16&)appName
+ targetName:(const base::string16&)targetName
+ requestAudio:(bool)requestAudio {
const NSUInteger kStyleMask =
NSTitledWindowMask | NSClosableWindowMask | NSResizableWindowMask;
base::scoped_nsobject<NSWindow> window(
@@ -83,7 +86,20 @@ const int kExcessButtonPadding = 6;
[self initializeContentsWithAppName:appName
targetName:targetName
requestAudio:requestAudio];
- media_list_ = std::move(media_list);
+ std::vector<std::unique_ptr<DesktopMediaList>> media_lists;
+ if (screen_list)
+ media_lists.push_back(std::move(screen_list));
+
+ if (window_list)
+ media_lists.push_back(std::move(window_list));
+
+ if (tab_list)
+ media_lists.push_back(std::move(tab_list));
+
+ if (media_lists.size() > 1)
+ media_list_.reset(new CombinedDesktopMediaList(media_lists));
+ else
+ media_list_ = std::move(media_lists[0]);
media_list_->SetViewDialogWindowId(content::DesktopMediaID(
content::DesktopMediaID::TYPE_WINDOW, [window windowNumber]));
doneCallback_ = callback;

Powered by Google App Engine
This is Rietveld 408576698