Desktop Capture Picker New UI: Preliminary Refactor

chrome/browser/media/desktop_media_picker.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_MEDIA_DESKTOP_MEDIA_PICKER_H_
 #define CHROME_BROWSER_MEDIA_DESKTOP_MEDIA_PICKER_H_
 
 #include <memory>
 
 #include "base/callback_forward.h"
@@ skipping 15 matching lines @@
   typedef base::Callback<void(content::DesktopMediaID)> DoneCallback;
 
   // Creates default implementation of DesktopMediaPicker for the current
   // platform.
   static std::unique_ptr<DesktopMediaPicker> Create();
 
   DesktopMediaPicker() {}
   virtual ~DesktopMediaPicker() {}
 
   // Shows dialog with list of desktop media sources (screens, windows, tabs)
-  // provided by |list| and calls |done_callback| when user chooses one of the
+  // provided by |screen_list|, |window_list| and |tab_list|.
+  // Dialog window will call |done_callback| when user chooses one of the
   // sources or closes the dialog.
   virtual void Show(content::WebContents* web_contents,
                     gfx::NativeWindow context,
                     gfx::NativeWindow parent,
                     const base::string16& app_name,
                     const base::string16& target_name,
-                    std::unique_ptr<DesktopMediaList> list,
+                    std::unique_ptr<DesktopMediaList> screen_list,
+                    std::unique_ptr<DesktopMediaList> window_list,
+                    std::unique_ptr<DesktopMediaList> tab_list,
                     bool request_audio,

[Sergey Ulanov, 2016/04/14 22:39:52]

nit, not for this cl: there 4 parameters can be bundled together in a struct.

[qiangchen, 2016/04/15 19:33:30]

Good suggestion.

                     const DoneCallback& done_callback) = 0;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(DesktopMediaPicker);
 };
 
 #endif  // CHROME_BROWSER_MEDIA_DESKTOP_MEDIA_PICKER_H_