Desktop Capture Picker New UI: Preliminary Refactor

chrome/browser/ui/views/desktop_media_picker_views_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/desktop_media_picker_views.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/run_loop.h"
@@ skipping 11 matching lines @@
 #include "ui/views/window/dialog_delegate.h"
 
 namespace views {
 
 class DesktopMediaPickerViewsTest : public testing::Test {
  public:
   DesktopMediaPickerViewsTest() {}
   ~DesktopMediaPickerViewsTest() override {}
 
   void SetUp() override {
-    media_list_ = new FakeDesktopMediaList();
-    std::unique_ptr<FakeDesktopMediaList> media_list(media_list_);
+    screen_list_ = new FakeDesktopMediaList();
+    window_list_ = new FakeDesktopMediaList();
+    tab_list_ = new FakeDesktopMediaList();
+    std::unique_ptr<FakeDesktopMediaList> screen_list(screen_list_);
+    std::unique_ptr<FakeDesktopMediaList> window_list(window_list_);
+    std::unique_ptr<FakeDesktopMediaList> tab_list(tab_list_);
 
     base::string16 app_name = base::ASCIIToUTF16("foo");
 
     picker_views_.reset(new DesktopMediaPickerViews());
     picker_views_->Show(NULL, test_helper_.GetContext(), NULL, app_name,
-                        app_name, std::move(media_list), false,
+                        app_name, std::move(screen_list),
+                        std::move(window_list), std::move(tab_list), false,
                         base::Bind(&DesktopMediaPickerViewsTest::OnPickerDone,
                                    base::Unretained(this)));
   }
 
   void TearDown() override {
     if (GetPickerDialogView()) {
       EXPECT_CALL(*this, OnPickerDone(content::DesktopMediaID()));
       GetPickerDialogView()->GetWidget()->CloseNow();
     }
   }
 
   DesktopMediaPickerDialogView* GetPickerDialogView() const {
     return picker_views_->GetDialogViewForTesting();
   }
 
   MOCK_METHOD1(OnPickerDone, void(content::DesktopMediaID));
 
  protected:
   content::TestBrowserThreadBundle thread_bundle_;
   views::ScopedViewsTestHelper test_helper_;
-  FakeDesktopMediaList* media_list_;
+  FakeDesktopMediaList* screen_list_;
+  FakeDesktopMediaList* window_list_;
+  FakeDesktopMediaList* tab_list_;
   std::unique_ptr<DesktopMediaPickerViews> picker_views_;
 };
 
 TEST_F(DesktopMediaPickerViewsTest, DoneCallbackCalledWhenWindowClosed) {
   EXPECT_CALL(*this, OnPickerDone(content::DesktopMediaID()));
 
   GetPickerDialogView()->GetWidget()->Close();
   base::RunLoop().RunUntilIdle();
 }
 
 TEST_F(DesktopMediaPickerViewsTest, DoneCallbackCalledOnOkButtonPressed) {
   const int kFakeId = 222;
   EXPECT_CALL(*this,
               OnPickerDone(content::DesktopMediaID(
                   content::DesktopMediaID::TYPE_WINDOW, kFakeId)));
-  media_list_->AddSource(kFakeId);
+  window_list_->AddSource(kFakeId);
 
   EXPECT_FALSE(
       GetPickerDialogView()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
 
   GetPickerDialogView()->GetMediaSourceViewForTesting(0)->OnFocus();
   EXPECT_TRUE(
       GetPickerDialogView()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
 
   GetPickerDialogView()->GetDialogClientView()->AcceptWindow();
   base::RunLoop().RunUntilIdle();
 }
 
 // Verifies that a MediaSourceView is selected with mouse left click and
 // original selected MediaSourceView gets unselected.
 TEST_F(DesktopMediaPickerViewsTest, SelectMediaSourceViewOnSingleClick) {
-  media_list_->AddSource(0);
-  media_list_->AddSource(1);
+  window_list_->AddSource(0);
+  window_list_->AddSource(1);
 
   DesktopMediaSourceView* source_view_0 =
       GetPickerDialogView()->GetMediaSourceViewForTesting(0);
 
   DesktopMediaSourceView* source_view_1 =
       GetPickerDialogView()->GetMediaSourceViewForTesting(1);
 
   // Both media source views are not selected initially.
   EXPECT_FALSE(source_view_0->is_selected());
   EXPECT_FALSE(source_view_1->is_selected());
@@ skipping 13 matching lines @@
   EXPECT_FALSE(source_view_0->is_selected());
   EXPECT_TRUE(source_view_1->is_selected());
 }
 
 TEST_F(DesktopMediaPickerViewsTest, DoneCallbackCalledOnDoubleClick) {
   const int kFakeId = 222;
   EXPECT_CALL(*this,
               OnPickerDone(content::DesktopMediaID(
                   content::DesktopMediaID::TYPE_WINDOW, kFakeId)));
 
-  media_list_->AddSource(kFakeId);
+  window_list_->AddSource(kFakeId);
 
   ui::MouseEvent double_click(ui::ET_MOUSE_PRESSED, gfx::Point(), gfx::Point(),
                               ui::EventTimeForNow(),
                               ui::EF_LEFT_MOUSE_BUTTON | ui::EF_IS_DOUBLE_CLICK,
                               ui::EF_LEFT_MOUSE_BUTTON);
 
   GetPickerDialogView()->GetMediaSourceViewForTesting(0)->OnMousePressed(
       double_click);
   base::RunLoop().RunUntilIdle();
 }
 
 TEST_F(DesktopMediaPickerViewsTest, DoneCallbackCalledOnDoubleTap) {
   const int kFakeId = 222;
   EXPECT_CALL(*this,
               OnPickerDone(content::DesktopMediaID(
                   content::DesktopMediaID::TYPE_WINDOW, kFakeId)));
 
-  media_list_->AddSource(kFakeId);
+  window_list_->AddSource(kFakeId);
   ui::GestureEventDetails details(ui::ET_GESTURE_TAP);
   details.set_tap_count(2);
   ui::GestureEvent double_tap(10, 10, 0, base::TimeDelta(), details);
 
   GetPickerDialogView()->GetMediaSourceViewForTesting(0)->OnGestureEvent(
       &double_tap);
   base::RunLoop().RunUntilIdle();
 }
 
 TEST_F(DesktopMediaPickerViewsTest, CancelButtonAlwaysEnabled) {
   EXPECT_TRUE(
       GetPickerDialogView()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_CANCEL));
 }
 
 // Verifies that the MediaSourceView is added or removed when |media_list_| is
 // updated.
 TEST_F(DesktopMediaPickerViewsTest, AddAndRemoveMediaSource) {
   // No media source at first.
   EXPECT_EQ(NULL, GetPickerDialogView()->GetMediaSourceViewForTesting(0));
 
   for (int i = 0; i < 3; ++i) {
-    media_list_->AddSource(i);
+    window_list_->AddSource(i);
     EXPECT_TRUE(GetPickerDialogView()->GetMediaSourceViewForTesting(i));
   }
 
   for (int i = 2; i >= 0; --i) {
-    media_list_->RemoveSource(i);
+    window_list_->RemoveSource(i);
     EXPECT_EQ(NULL, GetPickerDialogView()->GetMediaSourceViewForTesting(i));
   }
 }
 
 // Verifies that focusing the MediaSourceView marks it selected and the
 // original selected MediaSourceView gets unselected.
 TEST_F(DesktopMediaPickerViewsTest, FocusMediaSourceViewToSelect) {
-  media_list_->AddSource(0);
-  media_list_->AddSource(1);
+  window_list_->AddSource(0);
+  window_list_->AddSource(1);
 
   DesktopMediaSourceView* source_view_0 =
       GetPickerDialogView()->GetMediaSourceViewForTesting(0);
 
   DesktopMediaSourceView* source_view_1 =
       GetPickerDialogView()->GetMediaSourceViewForTesting(1);
 
   EXPECT_FALSE(source_view_0->is_selected());
   EXPECT_FALSE(source_view_1->is_selected());
 
   source_view_0->OnFocus();
   EXPECT_TRUE(source_view_0->is_selected());
 
   // Removing the focus does not undo the selection.
   source_view_0->OnBlur();
   EXPECT_TRUE(source_view_0->is_selected());
 
   source_view_1->OnFocus();
   EXPECT_FALSE(source_view_0->is_selected());
   EXPECT_TRUE(source_view_1->is_selected());
 }
 
 TEST_F(DesktopMediaPickerViewsTest, OkButtonDisabledWhenNoSelection) {
-  media_list_->AddSource(111);
+  window_list_->AddSource(111);
 
   EXPECT_FALSE(
       GetPickerDialogView()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
 
   GetPickerDialogView()->GetMediaSourceViewForTesting(0)->OnFocus();
   EXPECT_TRUE(
       GetPickerDialogView()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
 
-  media_list_->RemoveSource(0);
+  window_list_->RemoveSource(0);
   EXPECT_FALSE(
       GetPickerDialogView()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
 }
 
 // Verifies that the MediaListView get the initial focus.
 TEST_F(DesktopMediaPickerViewsTest, ListViewHasInitialFocus) {
   EXPECT_TRUE(GetPickerDialogView()->GetMediaListViewForTesting()->HasFocus());
 }
 
 }  // namespace views