Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1880653002: nullptr -> "sans-serif" fixes bold in gm/colorwheel (Closed)

Created:
4 years, 8 months ago by mtklein_C
Modified:
4 years, 8 months ago
Reviewers:
mtklein, caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

nullptr -> "sans-serif" fixes bold in gm/colorwheel This was an odd case where 8888 drew wrong and serialize-8888 was correct. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1880653002 Committed: https://skia.googlesource.com/skia/+/ad6a1901d174228d381c8e30b7e4d272a826dd50

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -66 lines) Patch
M gm/colorwheel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/dm_flags.json View 16 chunks +0 lines, -64 lines 0 comments Download
M tools/dm_flags.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
mtklein_C
4 years, 8 months ago (2016-04-11 19:48:59 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880653002/1
4 years, 8 months ago (2016-04-11 19:49:02 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-11 20:02:02 UTC) #7
caryclark
lgtm
4 years, 8 months ago (2016-04-11 20:15:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880653002/1
4 years, 8 months ago (2016-04-11 20:19:00 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 20:20:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ad6a1901d174228d381c8e30b7e4d272a826dd50

Powered by Google App Engine
This is Rietveld 408576698