Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 1880643002: X11: Set window class for content_shell. (Closed)

Created:
4 years, 8 months ago by mstensho (USE GERRIT)
Modified:
4 years, 8 months ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, Peter Beverloo, jam, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

X11: Set window class for content_shell. For Chrome, this happens in DesktopBrowserFrameAuraLinux::GetWidgetParams(), but there was no counterpart for content_shell. Setting a window class makes it easier to customize one's window manager for content_shell. R=peter@chromium.org Committed: https://crrev.com/d7e8771ac0284aff236c22e720f0d8951f5166a7 Cr-Commit-Position: refs/heads/master@{#386657}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/shell/browser/shell_views.cc View 1 chunk +2 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (2 generated)
mstensho (USE GERRIT)
4 years, 8 months ago (2016-04-11 19:38:50 UTC) #1
Peter Beverloo
lgtm https://codereview.chromium.org/1880643002/diff/1/content/shell/browser/shell_views.cc File content/shell/browser/shell_views.cc (right): https://codereview.chromium.org/1880643002/diff/1/content/shell/browser/shell_views.cc#newcode475 content/shell/browser/shell_views.cc:475: params.wm_class_name = params.wm_class_class; Random jotting so that I ...
4 years, 8 months ago (2016-04-12 11:24:41 UTC) #2
mstensho (USE GERRIT)
On 2016/04/12 11:24:41, Peter Beverloo wrote: > lgtm > > https://codereview.chromium.org/1880643002/diff/1/content/shell/browser/shell_views.cc > File content/shell/browser/shell_views.cc (right): ...
4 years, 8 months ago (2016-04-12 11:27:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880643002/1
4 years, 8 months ago (2016-04-12 11:27:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 12:10:51 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 12:11:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d7e8771ac0284aff236c22e720f0d8951f5166a7
Cr-Commit-Position: refs/heads/master@{#386657}

Powered by Google App Engine
This is Rietveld 408576698