X11: Set window class for content_shell.

X11: Set window class for content_shell.

For Chrome, this happens in DesktopBrowserFrameAuraLinux::GetWidgetParams(),
but there was no counterpart for content_shell.

Setting a window class makes it easier to customize one's window manager for
content_shell.

R=peter@chromium.org

Committed: https://crrev.com/d7e8771ac0284aff236c22e720f0d8951f5166a7
Cr-Commit-Position: refs/heads/master@{#386657}

[Peter Beverloo, 2016-04-12 11:24:41]

lgtm

https://codereview.chromium.org/1880643002/diff/1/content/shell/browser/shell...
File content/shell/browser/shell_views.cc (right):

https://codereview.chromium.org/1880643002/diff/1/content/shell/browser/shell...
content/shell/browser/shell_views.cc:475: params.wm_class_name =
params.wm_class_class;
Random jotting so that I understand this (nothing actionable)-- 

For non-official Linux builds this is "chromium-browser" by default, but can be
overridden by the CHROME_DESKTOP environment variable.

wm_class_name will be specialized if (a) it's a Chrome App window, or (b) a
custom --user-data-dir has been set. Neither applies to Content Shell, and we
can always add an environment variable later :-).

[mstensho (USE GERRIT), 2016-04-12 11:27:39]

On 2016/04/12 11:24:41, Peter Beverloo wrote:
> lgtm
> 
>
https://codereview.chromium.org/1880643002/diff/1/content/shell/browser/shell...
> File content/shell/browser/shell_views.cc (right):
> 
>
https://codereview.chromium.org/1880643002/diff/1/content/shell/browser/shell...
> content/shell/browser/shell_views.cc:475: params.wm_class_name =
> params.wm_class_class;
> Random jotting so that I understand this (nothing actionable)-- 
> 
> For non-official Linux builds this is "chromium-browser" by default, but can
be
> overridden by the CHROME_DESKTOP environment variable.
> 
> wm_class_name will be specialized if (a) it's a Chrome App window, or (b) a
> custom --user-data-dir has been set. Neither applies to Content Shell, and we
> can always add an environment variable later :-).

Thanks for reviewing!

[mstensho (USE GERRIT), 2016-04-12 11:27:43]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2016-04-12 11:27:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1880643002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1880643002/1

[commit-bot: I haz the power, 2016-04-12 12:10:51]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-12 12:11:41]

Description was changed from

==========
X11: Set window class for content_shell.

For Chrome, this happens in DesktopBrowserFrameAuraLinux::GetWidgetParams(),
but there was no counterpart for content_shell.

Setting a window class makes it easier to customize one's window manager for
content_shell.

R=peter@chromium.org
==========

to

==========
X11: Set window class for content_shell.

For Chrome, this happens in DesktopBrowserFrameAuraLinux::GetWidgetParams(),
but there was no counterpart for content_shell.

Setting a window class makes it easier to customize one's window manager for
content_shell.

R=peter@chromium.org

Committed: https://crrev.com/d7e8771ac0284aff236c22e720f0d8951f5166a7
Cr-Commit-Position: refs/heads/master@{#386657}
==========

[commit-bot: I haz the power, 2016-04-12 12:11:42]

Patchset 1 (id:??) landed as
https://crrev.com/d7e8771ac0284aff236c22e720f0d8951f5166a7
Cr-Commit-Position: refs/heads/master@{#386657}