Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1880503002: Replace the "OK" button with "Ok, got it" in the Clear Browsing Data dialog (Closed)

Created:
4 years, 8 months ago by msramek
Modified:
4 years, 8 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace the "OK" button with "Ok, got it" in the Clear Browsing Data dialog BUG=602253 Committed: https://crrev.com/9eadaadadad919da17f2f954d63f1c522d434f28 Cr-Commit-Position: refs/heads/master@{#386632}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/resources/options/clear_browser_data_history_notice_overlay.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/clear_browser_data_handler.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
msramek
Hi Dan, please have a look! This is just a tiny fix for https://codereview.chromium.org/1813023002/ where ...
4 years, 8 months ago (2016-04-11 16:01:11 UTC) #2
Dan Beam
lgtm
4 years, 8 months ago (2016-04-11 23:43:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880503002/1
4 years, 8 months ago (2016-04-12 08:38:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 09:16:01 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 09:17:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9eadaadadad919da17f2f954d63f1c522d434f28
Cr-Commit-Position: refs/heads/master@{#386632}

Powered by Google App Engine
This is Rietveld 408576698