Move TrapReason messages over to messages.h

Move TrapReason messages over to messages.h

This prepares a patch to throw actual errors instead of just strings on
wasm traps. In order to accomplish this, the messages need to be known
to the runtime, as the generated code will just pass the message id.

R=mstarzinger@chromium.org, titzer@chromium.org
BUG=

Committed: https://crrev.com/ce669d792c0f5c06ea6bb4839f84ef802348bcf7
Cr-Commit-Position: refs/heads/master@{#35628}

[Michael Starzinger, 2016-04-11 14:05:24]

LGTM on messages.h changes.

https://codereview.chromium.org/1880493002/diff/1/src/wasm/wasm-opcodes.h
File src/wasm/wasm-opcodes.h (right):

https://codereview.chromium.org/1880493002/diff/1/src/wasm/wasm-opcodes.h#new...
src/wasm/wasm-opcodes.h:9: #include "src/messages.h"
nit: Not sure about the header inclusion policy in WAMS, "wasm-opcodes.h" sounds
like a pretty central header. Not sure if it should pull in "messages.h". But
that is internal to WASM, so I don't mind either way.

https://codereview.chromium.org/1880493002/diff/1/src/wasm/wasm-opcodes.h#new...
src/wasm/wasm-opcodes.h:530: static const char* TrapReasonName(TrapReason
reason) {
nit/suggestion: Calling this "TrapReasonMessage" would make more sense now IMHO.
But that is internal to WASM, so I don't mind either way.

[Clemens Hammacher, 2016-04-11 16:57:30]

On 2016/04/11 at 14:05:24, mstarzinger wrote:
> LGTM on messages.h changes.
> 
> https://codereview.chromium.org/1880493002/diff/1/src/wasm/wasm-opcodes.h
> File src/wasm/wasm-opcodes.h (right):
> 
>
https://codereview.chromium.org/1880493002/diff/1/src/wasm/wasm-opcodes.h#new...
> src/wasm/wasm-opcodes.h:9: #include "src/messages.h"
> nit: Not sure about the header inclusion policy in WAMS, "wasm-opcodes.h"
sounds like a pretty central header. Not sure if it should pull in "messages.h".
But that is internal to WASM, so I don't mind either way.
> 
>
https://codereview.chromium.org/1880493002/diff/1/src/wasm/wasm-opcodes.h#new...
> src/wasm/wasm-opcodes.h:530: static const char* TrapReasonName(TrapReason
reason) {
> nit/suggestion: Calling this "TrapReasonMessage" would make more sense now
IMHO. But that is internal to WASM, so I don't mind either way.

Sounds all reasonable, I have addressed it in the new patch.

[JF, 2016-04-11 18:26:17]

jfb@chromium.org changed reviewers:
+ jfb@chromium.org

[JF, 2016-04-11 18:26:17]

lgtm

[titzer, 2016-04-18 16:20:27]

On 2016/04/11 18:26:17, JF wrote:
> lgtm

lgtm

[Clemens Hammacher, 2016-04-19 15:32:42]

The CQ bit was checked by clemensh@chromium.org

[Clemens Hammacher, 2016-04-19 15:32:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org, jfb@chromium.org
Link to the patchset: https://codereview.chromium.org/1880493002/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2016-04-19 15:32:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1880493002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1880493002/80001

[commit-bot: I haz the power, 2016-04-19 15:56:20]

Committed patchset #5 (id:80001)

[nodir1, 2016-04-22 18:43:06]

Description was changed from

==========
Move TrapReason messages over to messages.h

This prepares a patch to throw actual errors instead of just strings on
wasm traps. In order to accomplish this, the messages need to be known
to the runtime, as the generated code will just pass the message id.

R=mstarzinger@chromium.org, titzer@chromium.org
BUG=
==========

to

==========
Move TrapReason messages over to messages.h

This prepares a patch to throw actual errors instead of just strings on
wasm traps. In order to accomplish this, the messages need to be known
to the runtime, as the generated code will just pass the message id.

R=mstarzinger@chromium.org, titzer@chromium.org
BUG=

Committed: https://crrev.com/ce669d792c0f5c06ea6bb4839f84ef802348bcf7
Cr-Commit-Position: refs/heads/master@{#35628}
==========

[nodir1, 2016-04-22 18:43:07]

Patchset 5 (id:??) landed as
https://crrev.com/ce669d792c0f5c06ea6bb4839f84ef802348bcf7
Cr-Commit-Position: refs/heads/master@{#35628}