Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-basics.html

Issue 1880393002: CREDENTIAL: Implement 'SiteBoundCredential'. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Feedback. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/credentialmanager/idl.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-basics.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-basics.html b/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-basics.html
index 2aad940f8d1c778082891ea1f2103faaac0a5b96..b8638d1c091f48eebf4cd9045b0d803c435fddd4 100644
--- a/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-basics.html
+++ b/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-basics.html
@@ -10,15 +10,15 @@ function stubResolverUndefinedChecker(c) {
}
function stubRejectionChecker(reason) {
- assert_unreached("get() should not reject, but did: " + reason.name);
+ assert_unreached("get(...) should not reject, but did: " + reason.name);
}
(function() {
var t = async_test("Verify the basics of get().");
t.step(function () {
navigator.credentials.get().then(
- t.step_func(stubResolverUndefinedChecker.bind(t)),
- t.step_func(stubRejectionChecker.bind(t)));
+ t.unreached_func(),
+ t.step_func(t.done.bind(t)));
philipj_slow 2016/04/25 11:54:21 Looks a bit odd, would t.step_func_done() suffice?
Mike West 2016/04/25 13:03:31 Yes, it would. Thanks!
});
}());
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/credentialmanager/idl.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698