third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp - Issue 1880393002: CREDENTIAL: Implement 'SiteBoundCredential'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp

Issue 1880393002: CREDENTIAL: Implement 'SiteBoundCredential'. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/credentialmanager/idl-expected.txt ('K') | « third_party/WebKit/Source/modules/credentialmanager/Credential.idl ('k') | third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.h » ('j') | third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp

diff --git a/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp b/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp

index 98dc149bacb0fa1a387e88926365ced9303c5511..2817538f20b16dedbe9655ccd5154bc51a803fd9 100644

--- a/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp

+++ b/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp

@@ -5,6 +5,7 @@

#include "modules/credentialmanager/CredentialsContainer.h"

#include "bindings/core/v8/Dictionary.h"

+#include "bindings/core/v8/ExceptionMessages.h"

philipj_slow 2016/04/19 09:20:36 Added header but no other changes?

Mike West 2016/04/25 10:20:13 Yeah. Dropped, thanks!

#include "bindings/core/v8/ScriptPromise.h"

#include "bindings/core/v8/ScriptPromiseResolver.h"

#include "core/dom/DOMException.h"